ext/common.js - Issue 29723558: Issue 6482 - Use ES6 classes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: ext/common.js

Issue 29723558: Issue 6482 - Use ES6 classes (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/

Patch Set: Created March 15, 2018, 7:46 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: ext/common.js

===================================================================

--- a/ext/common.js

+++ b/ext/common.js

@@ -15,29 +15,33 @@

* along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.

"use strict";

{

window.ext = {};

- let EventTarget = ext._EventTarget = function()

+ ext._EventTarget = class

{

- this._listeners = new Set();

- };

- EventTarget.prototype = {

+ constructor()

+ {

+ this._listeners = new Set();

+ }

addListener(listener)

{

this._listeners.add(listener);

- },

+ }

removeListener(listener)

{

this._listeners.delete(listener);

- },

+ }

_dispatch(...args)

{

let results = [];

for (let listener of this._listeners)

results.push(listener(...args));

return results;