Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(392)

Issue 29723586: Issue 6484 - Add horizontal-list class to website-defaults (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 8 months ago by ire
Modified:
1 year, 8 months ago
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/website-defaults
Visibility:
Public.

Description

Issue 6484 - Add horizontal-list class to website-defaults

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments #2 #

Total comments: 2

Patch Set 3 : Add comma-separated class #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -0 lines) Patch
M pages/utilities.html View 1 2 2 chunks +20 lines, -0 lines 0 comments Download
M static/scss/main.scss View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A static/scss/utilities/_lists.scss View 1 2 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 7
ire
1 year, 8 months ago (2018-03-15 09:37:12 UTC) #1
juliandoucette
No example page? https://codereview.adblockplus.org/29723586/diff/29723587/static/scss/utilities/_lists.scss File static/scss/utilities/_lists.scss (right): https://codereview.adblockplus.org/29723586/diff/29723587/static/scss/utilities/_lists.scss#newcode31 static/scss/utilities/_lists.scss:31: .content .horizontal-list, I think it's OK ...
1 year, 8 months ago (2018-03-24 15:48:09 UTC) #2
ire
On 2018/03/24 15:48:09, juliandoucette wrote: > No example page? Added to the utilities page. https://codereview.adblockplus.org/29723586/diff/29723587/static/scss/utilities/_lists.scss ...
1 year, 8 months ago (2018-03-26 06:59:39 UTC) #3
juliandoucette
LGTM + NIT https://codereview.adblockplus.org/29723586/diff/29733595/pages/utilities.html File pages/utilities.html (right): https://codereview.adblockplus.org/29723586/diff/29733595/pages/utilities.html#newcode47 pages/utilities.html:47: <li>List item 1</li> NIT: This could ...
1 year, 8 months ago (2018-04-03 13:35:13 UTC) #4
ire
https://codereview.adblockplus.org/29723586/diff/29733595/pages/utilities.html File pages/utilities.html (right): https://codereview.adblockplus.org/29723586/diff/29733595/pages/utilities.html#newcode47 pages/utilities.html:47: <li>List item 1</li> On 2018/04/03 13:35:13, juliandoucette wrote: > ...
1 year, 8 months ago (2018-04-03 14:36:34 UTC) #5
ire
New patch set up
1 year, 8 months ago (2018-04-03 14:41:58 UTC) #6
juliandoucette
1 year, 8 months ago (2018-04-03 14:51:38 UTC) #7
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5