Delta Between Two Patch Sets: pages/utilities.html
Issue 29723586:
Issue 6484 - Add horizontal-list class to website-defaults (Closed)
Base URL: https://hg.adblockplus.org/website-defaults
Left Patch Set: Addressed comments #2
Created March 26, 2018, 6:56 a.m.
Right Patch Set: Rebase
Created April 3, 2018, 2:41 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« no previous file
|
static/scss/main.scss » ('j')
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 title=Utilities | 1 title=Utilities |
| 2 description=HTML & SCSS component utilities | 2 description=HTML & SCSS component utilities |
| 3 | 3 |
| 4 <h1>Utilities</h1> | 4 <h1>Utilities</h1> |
| 5 <p>HTML & SCSS component utilities</p> | 5 <p>HTML & SCSS component utilities</p> |
| 6 | 6 |
| 7 <ol> | 7 <ol> |
| 8 <li><a href="#backgrounds">Backgrounds</a></li> | 8 <li><a href="#backgrounds">Backgrounds</a></li> |
| 9 <li><a href="#text-alignment">Text Alignment</a></li> | 9 <li><a href="#text-alignment">Text Alignment</a></li> |
| 10 <li><a href="#lead-text">Lead text</a></li> | 10 <li><a href="#lead-text">Lead text</a></li> |
| (...skipping 26 matching lines...) Expand all Loading... | |
| 37 <h2 id="lead-text">Lead text</h2> | 37 <h2 id="lead-text">Lead text</h2> |
| 38 | 38 |
| 39 <p class="lead"> "Lead text" is introductory text that is not part of a heading. </p> | 39 <p class="lead"> "Lead text" is introductory text that is not part of a heading. </p> |
| 40 | 40 |
| 41 <p>It is typically visually emphasized, not semantically emphasized, like <code> strong</code> or <code>em</code>.</p> | 41 <p>It is typically visually emphasized, not semantically emphasized, like <code> strong</code> or <code>em</code>.</p> |
| 42 | 42 |
| 43 | 43 |
| 44 <h2 id="horizontal-lists">Horizontal lists</h2> | 44 <h2 id="horizontal-lists">Horizontal lists</h2> |
| 45 | 45 |
| 46 <ul class="horizontal-list"> | 46 <ul class="horizontal-list"> |
| 47 <li>List item 1</li> | 47 <li>List item 1</li> |
|
juliandoucette
2018/04/03 13:35:13
NIT: This could use commas and/or a little spacing
ire
2018/04/03 14:36:33
I think that could be an enhancement, e.g. a comma
| |
| 48 <li>List item 2</li> | 48 <li>List item 2</li> |
| 49 <li>List item 3</li> | 49 <li>List item 3</li> |
| 50 <li>List item 4</li> | 50 <li>List item 4</li> |
| 51 </ul> | 51 </ul> |
| 52 | |
| 53 <h3>Comma-separated</h3> | |
| 54 | |
| 55 <ul class="horizontal-list comma-separated"> | |
| 56 <li>List item 1</li> | |
| 57 <li>List item 2</li> | |
| 58 <li>List item 3</li> | |
| 59 <li>List item 4</li> | |
| 60 </ul> | |
| LEFT | RIGHT |
« no previous file
|
static/scss/main.scss » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
