Issue 6382 - Catch InvalidAccessError exception when checking styles.

lib/content/elemHideEmulation.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 600 matching lines @@
       let rules;
       try
       {
         rules = stylesheet.cssRules;
       }
       catch (e)
       {
         // On Firefox, there is a chance that an InvalidAccessError
         // get thrown when accessing cssRules. Just skip the stylesheet
         // in that case.
-        // See https://issues.adblockplus.org/ticket/6382
+        // See https://searchfox.org/mozilla-central/rev/f65d7528e34ef1a7665b4a1a7b7cdb1388fcd3aa/layout/style/StyleSheet.cpp#699
         continue;

[kzar, 2018/04/18 16:12:30]

I wonder if we should check that the exception really is an InvalidAccessError
before continuing? Then we wouldn't ignore other exceptions, also we could
shorten the comment since the code would already be clear about the type of
exception we're worrying about.

[hub, 2018/04/18 18:48:23]

The intent here is to catch the exception to not interrupt the processing. There
is nothing much we can do instead so I don't think it matters.

[kzar, 2018/04/19 07:29:29]

Acknowledged.

       }
 
       if (!rules)
         continue;
 
       for (let rule of rules)
       {
         if (rule.type != rule.STYLE_RULE)
           continue;
 
@@ skipping 96 matching lines @@
         this.queueFiltering(params.stylesheets, params.mutations);
       }
     };
 
     if (this._scheduledProcessing)
     {
       if (!stylesheets && !mutations)
       {
         this._scheduledProcessing = {};
       }
-      else
+      else if (this._scheduledProcessing.stylesheets ||
+               this._scheduledProcessing.mutations)
       {
         if (stylesheets)
         {
           if (!this._scheduledProcessing.stylesheets)
             this._scheduledProcessing.stylesheets = [];
           this._scheduledProcessing.stylesheets.push(...stylesheets);
         }
         if (mutations)
         {
           if (!this._scheduledProcessing.mutations)
@@ skipping 16 matching lines @@
         this._scheduledProcessing = null;
         this._addSelectors(params.stylesheets, params.mutations, completion);
       },
       MIN_INVOCATION_INTERVAL - (performance.now() - this._lastInvocation));
     }
     else if (this.document.readyState == "loading")
     {
       this._scheduledProcessing = {stylesheets, mutations};
       let handler = () =>
       {
-        document.removeEventListener("DOMContentLoaded", handler);
+        this.document.removeEventListener("DOMContentLoaded", handler);
         let params = Object.assign({}, this._scheduledProcessing);
         this._filteringInProgress = true;
         this._scheduledProcessing = null;
         this._addSelectors(params.stylesheets, params.mutations, completion);
       };
-      document.addEventListener("DOMContentLoaded", handler);
+      this.document.addEventListener("DOMContentLoaded", handler);
     }
     else
     {
       this._filteringInProgress = true;
       this._addSelectors(stylesheets, mutations, completion);
     }
   },
 
   onLoad(event)
   {
@@ skipping 28 matching lines @@
           characterData: shouldObserveCharacterData(this.patterns),
           subtree: true
         }
       );
       this.document.addEventListener("load", this.onLoad.bind(this), true);
     }
   }
 };
 
 exports.ElemHideEmulation = ElemHideEmulation;