Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: ext/background.js

Issue 29723705: Noissue - Link to extension_urls::kChromeWebstoreBaseURL in comment (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set: Created March 16, 2018, 4:27 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ext/background.js
===================================================================
--- a/ext/background.js
+++ b/ext/background.js
@@ -263,16 +263,17 @@
// Since we can only listen for HTTP(S) responses using
// webRequest.onHeadersReceived we must update the page structure here for
// other navigations.
let {url} = details;
if (!(url.startsWith("http:") ||
url.startsWith("https:") &&
// Chrome doesn't dispatch webRequest.onHeadersReceived
// for Web Store URLs.
+ // https://crrev.com/76882bf/extensions/common/extension_urls.cc#33
!url.startsWith("https://chrome.google.com/webstore/")))
{
updatePageFrameStructure(details.frameId, details.tabId, url,
details.parentFrameId);
}
});
function forgetTab(tabId)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld