Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29726570: Issue 6496 - Account for browsers that don't support notifications with buttons (Closed)

Created:
March 18, 2018, 11:10 p.m. by Sebastian Noack
Modified:
March 19, 2018, 5:41 p.m.
Reviewers:
kzar
Visibility:
Public.

Description

Issue 6496 - Account for browsers that don't support notifications with buttons

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed typo in comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -10 lines) Patch
M lib/notificationHelper.js View 1 1 chunk +12 lines, -5 lines 0 comments Download
M lib/subscriptionInit.js View 2 chunks +35 lines, -5 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
March 18, 2018, 11:14 p.m. (2018-03-18 23:14:19 UTC) #1
kzar
Otherwise LGTM https://codereview.adblockplus.org/29726570/diff/29726571/lib/notificationHelper.js File lib/notificationHelper.js (right): https://codereview.adblockplus.org/29726570/diff/29726571/lib/notificationHelper.js#newcode212 lib/notificationHelper.js:212: // this, turns the synchronus error on ...
March 19, 2018, 8:34 a.m. (2018-03-19 08:34:59 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29726570/diff/29726571/lib/notificationHelper.js File lib/notificationHelper.js (right): https://codereview.adblockplus.org/29726570/diff/29726571/lib/notificationHelper.js#newcode212 lib/notificationHelper.js:212: // this, turns the synchronus error on Firefox into ...
March 19, 2018, 4:58 p.m. (2018-03-19 16:58:24 UTC) #3
kzar
March 19, 2018, 5:19 p.m. (2018-03-19 17:19:29 UTC) #4
LGTM++

Powered by Google App Engine
This is Rietveld