Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(436)

Issue 29727558: Issue 6489 - fix initialization moment of the default scheduler of DefaultPlatformBuilder (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years ago by sergei
Modified:
2 years ago
Reviewers:
René Jeschke, hub
CC:
anton
Base URL:
https://github.com/adblockplus/libadblockplus@cd1cd70ea3122fb4b8a96c40d96ce9b1ae5a3ae9
Visibility:
Public.

Patch Set 1 #

Total comments: 3

Patch Set 2 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -34 lines) Patch
M include/AdblockPlus/AsyncExecutor.h View 1 1 chunk +51 lines, -1 line 0 comments Download
M include/AdblockPlus/Platform.h View 3 chunks +9 lines, -0 lines 0 comments Download
M src/Platform.cpp View 5 chunks +13 lines, -33 lines 0 comments Download

Messages

Total messages: 4
sergei
https://codereview.adblockplus.org/29727558/diff/29727559/include/AdblockPlus/Platform.h File include/AdblockPlus/Platform.h (right): https://codereview.adblockplus.org/29727558/diff/29727559/include/AdblockPlus/Platform.h#newcode143 include/AdblockPlus/Platform.h:143: * Private If you find it confusing I can ...
2 years ago (2018-03-19 10:22:49 UTC) #1
hub
beside the small nit LGTM https://codereview.adblockplus.org/29727558/diff/29727559/include/AdblockPlus/AsyncExecutor.h File include/AdblockPlus/AsyncExecutor.h (right): https://codereview.adblockplus.org/29727558/diff/29727559/include/AdblockPlus/AsyncExecutor.h#newcode100 include/AdblockPlus/AsyncExecutor.h:100: * Destroyes internally held ...
2 years ago (2018-03-19 11:48:43 UTC) #2
sergei
https://codereview.adblockplus.org/29727558/diff/29727559/include/AdblockPlus/AsyncExecutor.h File include/AdblockPlus/AsyncExecutor.h (right): https://codereview.adblockplus.org/29727558/diff/29727559/include/AdblockPlus/AsyncExecutor.h#newcode100 include/AdblockPlus/AsyncExecutor.h:100: * Destroyes internally held `AsyncExecutor`, any subsequent calls of ...
2 years ago (2018-03-19 12:34:27 UTC) #3
hub
2 years ago (2018-03-19 13:10:38 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5