Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include/AdblockPlus/Platform.h

Issue 29727558: Issue 6489 - fix initialization moment of the default scheduler of DefaultPlatformBuilder (Closed) Base URL: https://github.com/adblockplus/libadblockplus@cd1cd70ea3122fb4b8a96c40d96ce9b1ae5a3ae9
Patch Set: Created March 19, 2018, 10:17 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: include/AdblockPlus/Platform.h
diff --git a/include/AdblockPlus/Platform.h b/include/AdblockPlus/Platform.h
index 7763627c7388ba9d331940329451d8310b2866d2..dd835471fbd828400a5543ad1a2e31882dac0972 100644
--- a/include/AdblockPlus/Platform.h
+++ b/include/AdblockPlus/Platform.h
@@ -32,6 +32,7 @@ namespace AdblockPlus
{
struct IV8IsolateProvider;
class JsEngine;
+ class OptionalAsyncExecutor;
/**
* AdblockPlus platform is the main component providing access to other
@@ -139,6 +140,13 @@ namespace AdblockPlus
{
public:
/**
+ * Private
sergei 2018/03/19 10:22:49 If you find it confusing I can just move it to Def
+ */
+ typedef std::shared_ptr<OptionalAsyncExecutor> AsyncExecutorPtr;
+
+ DefaultPlatformBuilder();
+
+ /**
* Constructs a default executor for asynchronous tasks. When Platform
* is being destroyed it starts to ignore new tasks and waits for finishing
* of already running tasks.
@@ -173,6 +181,7 @@ namespace AdblockPlus
*/
std::unique_ptr<Platform> CreatePlatform();
private:
+ AsyncExecutorPtr sharedAsyncExecutor;
Scheduler defaultScheduler;
};
}

Powered by Google App Engine
This is Rietveld