includes/index.tmpl - Issue 29727563: Fixes #35 - Progressively enhance install button with appropriate links and text

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: includes/index.tmpl

Issue 29727563: Fixes #35 - Progressively enhance install button with appropriate links and text (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org

Patch Set: Addressed comments #12 Created April 9, 2018, 9:22 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 title=Adblock Plus \| The world's # 1 free ad blocker

	2 description=Adblock Plus, the most popular ad blocker on Firefox, Chrome, Safari , Android and iOS. Block pop-ups and annoying ads on websites like Facebook and YouTube.

	3

	4 <head>

	5 <link rel="stylesheet" href="/css/index.css">

	6 <link rel="chrome-webstore-item" href="https://chrome.google.com/webstore/deta il/cfhdojbkjhnklbpkdaibdccddilifddb">

	7 </head>

	8

	9 <? include hero-download ?>

	10 <? include as-mentioned ?>

	11 <? include features ?>

	12 <? include abb-cross-promotion ?>

	13 <? include footnote ?>

	14

	15 <script id="hero-download-button-template" type="text/template">
	juliandoucette 2018/04/09 13:01:02 NIT: I'd prefer to output translations into a sing NIT: I'd prefer to output translations into a single JavaScript object instead of separate templates. ACK: This works and is convenient for this use case. (Meaning that you may ignore my NIT or choose to address it separately.) ire 2018/04/12 08:05:46 Ack, I think we can handle this separately then. Show quoted text On 2018/04/09 13:01:02, juliandoucette wrote: > NIT: I'd prefer to output translations into a single JavaScript object instead > of separate templates. > > ACK: This works and is convenient for this use case. (Meaning that you may > ignore my NIT or choose to address it separately.) Ack, I think we can handle this separately then.
	16 {% if locale in ["en", "de", "fr"] %}

	17 {{ "Agree and Install for <fix>browser</fix>" \| translate("agree-and-install -for-browser", "button label") }}

	18 {% else %}

	19 {{ "Install for <fix>browser</fix>" \| translate("install-for-browser", "butt on label") }}

	20 {% endif %}

	21 </script>

	22

	23 {% for browser in browsers %}

	24 <script id="{{ browser.id }}-name-translated" type="text/template">

	25 {{ browser.name \| translate(browser.id + "-name") }}

	26 </script>

	27 {% endfor %}

	28

	29 <script src="/js/vendor/bowser.js"></script>

	30 <script src="/js/index.js"></script>

OLD	NEW

« no previous file with comments | « includes/index.html ('k') | static/css/index.css » ('j') | static/js/index.js » ('J')