Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: static/js/index.js

Issue 29727563: Fixes #35 - Progressively enhance install button with appropriate links and text (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org
Patch Set: Change translation strings Created April 16, 2018, 3:06 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 "use strict";
2
3 (function()
4 {
5 var supportedPlatforms = {
6
7 // Desktop browsers
8 "chrome": "https://chrome.google.com/webstore/detail/cfhdojbkjhnklbpkdaibdcc ddilifddb",
9 "opera": "https://addons.opera.com/extensions/details/opera-adblock/?display =en-US",
10 "yandexbrowser": "https://chrome.google.com/webstore/detail/cfhdojbkjhnklbpk daibdccddilifddb",
11 "msie": "https://update.adblockplus.org/latest/adblockplusie.exe",
12 "msedge": "https://www.microsoft.com/store/p/adblock-plus/9nblggh4r9nz",
13 "firefox": "https://update.adblockplus.org/latest/adblockplusfirefox.xpi",
14 "safari": "https://update.adblockplus.org/latest/adblockplussafari.safariext z",
15 "maxthon": "",
16
17 // Mobile platforms
18 "ios": "https://eyeo.to/adblockbrowser/ios/abp-website",
19 "android": "https://eyeo.to/adblockbrowser/android/abp-website"
20 };
21
22 function setupHeroDownloadButton()
23 {
24 var detectedPlatform = Object.keys(supportedPlatforms)
25 .find(bowser.hasOwnProperty.bind(bowser));
26
27 if (!detectedPlatform) return;
28
29 document.body.classList.add(detectedPlatform);
30
31 if (detectedPlatform == "maxthon") return;
32
33 var heroDownloadButton = document.getElementById("hero-download-button");
34 heroDownloadButton.href = supportedPlatforms[detectedPlatform];
35 heroDownloadButton.innerHTML = document
juliandoucette 2018/04/16 15:44:41 NIT/Suggest: innerText (we don't support IE 8 anym
ire 2018/04/16 16:00:59 Changed to textContent which seems to be better fo
juliandoucette 2018/04/16 16:12:58 Thanks! (Facepalm: I meant to say textContent. My
36 .getElementById("hero-download-button-template-" + detectedPlatform)
37 .innerHTML;
38
39 heroDownloadButton.addEventListener("click", function(event)
40 {
41 if (typeof chrome == "undefined") return;
42 event.preventDefault();
43
44 try
juliandoucette 2018/04/16 15:44:41 TOL: Why are curly braces required for try/catch s
ire 2018/04/16 16:00:59 I know right?!?! Maybe there's a good reason I don
45 {
46 chrome.webstore.install();
47 }
48 catch(error)
49 {
50 window.location = "/" + this.hreflang + "/download";
51 }
52 });
53 }
54
55 if (typeof bowser != "undefined") setupHeroDownloadButton();
56
57 }());
OLDNEW
« static/css/index.css ('K') | « static/css/index.css ('k') | static/js/vendor/bowser.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld