Delta Between Two Patch Sets: includes/index.tmpl
Issue 29727563:
Fixes #35 - Progressively enhance install button with appropriate links and text (Closed)
Base URL: https://hg.adblockplus.org/web.adblockplus.org
Left Patch Set: Rebase
Created March 21, 2018, 9:16 a.m.
Right Patch Set: Addressed comments #21
Created April 16, 2018, 4 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« includes/index.html ('k')
|
static/css/index.css » ('j')
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 title=Adblock Plus - Surf the web without annoying ads! | 1 title=Adblock Plus | The world's # 1 free ad blocker |
| 2 description=Adblock Plus is the most popular ad blocker available for Firefox, C hrome, Opera, Safari, Android and Internet Explorer. Block all annoying ads all over the web: remove video ads on YouTube, block Facebook ads, get rid of pop-up s and much more. On Google Chrome, Adblock Plus is one of the fastest growing ex tensions ever. Adblock Plus is used on over 100 million devices. Download online for free now! | 2 description=Adblock Plus, the most popular ad blocker on Firefox, Chrome, Safari , Android and iOS. Block pop-ups and annoying ads on websites like Facebook and YouTube. |
| 3 | 3 |
| 4 <head> | 4 <head> |
| 5 <link rel="stylesheet" href="/css/index.css"> | 5 <link rel="stylesheet" href="/css/index.css"> |
| 6 <link rel="chrome-webstore-item" href="https://chrome.google.com/webstore/deta il/cfhdojbkjhnklbpkdaibdccddilifddb"> | |
| 6 </head> | 7 </head> |
| 7 | 8 |
| 8 <? include hero-download ?> | 9 <? include hero-download ?> |
| 9 <? include as-mentioned ?> | 10 <? include as-mentioned ?> |
| 10 <? include features ?> | 11 <? include features ?> |
| 11 <? include cross-promotion ?> | 12 <? include abb-cross-promotion ?> |
| 12 <? include footnote ?> | 13 <? include footnote ?> |
| 13 | 14 |
| 14 <script id="hero-download-button-template" type="text/template"> | 15 {% for browser in browsers %} |
| 16 <script id="download-label-{{ browser.id }}" type="text/template"> | |
| 15 {% if locale in ["en", "de", "fr"] %} | 17 {% if locale in ["en", "de", "fr"] %} |
| 16 {{ "Agree and Install for <fix>browser</fix>" | translate("agree-and-install -for-browser", "button label") }} | 18 {{ "Agree and Install for " + browser.name | translate("agree-and-install-fo r-" + browser.id, "button label") }} |
| 17 {% else %} | 19 {% else %} |
| 18 {{ "Install for <fix>browser</fix>" | translate("install-for-browser", "bu tt | 20 {{ "Install for " + browser.name | translate("install-for-" + browser.id, "b utton label") }} |
|
saroyanm
2018/03/23 19:08:36
The installation "visited" state of this button is
ire
2018/03/26 10:23:00
This issue was fixed in https://codereview.adblock
| |
| 19 on label") }} | |
| 20 {% endif %} | 21 {% endif %} |
| 21 </script> | 22 </script> |
| 23 {% endfor %} | |
| 22 | 24 |
| 23 <script src="/js/vendor/bowser.js"></script> | 25 <script src="/js/vendor/bowser.js"></script> |
| 24 <script src="/js/index.js"></script> | 26 <script src="/js/index.js"></script> |
| LEFT | RIGHT |
« includes/index.html ('k')
|
static/css/index.css » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
