Fixes #35 - Progressively enhance install button with appropriate links and text

static/js/index.js

 "use strict";
 
 (function()
 {
   var supportedPlatforms = {

[saroyanm, 2018/03/23 19:08:37]

I wonder what SEO implications this can introduce, as we used to have a separate
page for each browser, but now we are introducing 1 page instead?
Are we going to generate pages for each platform, or introduce redirections ?
Maybe having a separate page for each browser can help us with SEO ? 
I assume all this was discussed, so would be great to send a link or, maybe we
can discuss the implications.

[ire, 2018/03/26 10:23:01]

This is a good point. As I wasn't part of the initial conversations around the
abp redesign, I'm not aware of if this was discussed. Julian may be able to
answer your question or, if not, we can bring this up in the issue. 

+
     // Desktop browsers
-    "chrome": {
-      installer: "https://chrome.google.com/webstore/detail/cfhdojbkjhnklbpkdaibdccddilifddb",

[saroyanm, 2018/03/23 19:08:37]

Seems like here we also don't have inline installation, same as here ->
https://codereview.adblockplus.org/29722640/diff/29723573/pages/download.tmpl...

[ire, 2018/03/26 10:23:01]

Done.

-      label: "Chrome"
-    },
-    "opera": {
-      installer: "https://addons.opera.com/extensions/details/opera-adblock/?display=en-US",
-      label: "Opera"
-    },
-    "yandexbrowser": {
-      installer: "https://chrome.google.com/webstore/detail/cfhdojbkjhnklbpkdaibdccddilifddb",
-      label: "Yandex Browser"
-    },
-    "msie": {
-      installer: "https://update.adblockplus.org/latest/adblockplusie.exe",
-      label: "Internet Explorer"
-    },
-    "msedge": {
-      installer: "https://www.microsoft.com/store/p/adblock-plus/9nblggh4r9nz",
-      label: "Micrsoft Edge"
-    },
-    "firefox": {
-      installer: "https://update.adblockplus.org/latest/adblockplusfirefox.xpi",
-      label: "Firefox"
-    },
-    "safari": {
-      installer: "https://update.adblockplus.org/latest/adblockplussafari.safariextz",
-      label: "Safari"
-    },
+    "chrome": "https://chrome.google.com/webstore/detail/cfhdojbkjhnklbpkdaibdccddilifddb",
+    "opera": "https://addons.opera.com/extensions/details/opera-adblock/?display=en-US",
+    "yandexbrowser": "https://chrome.google.com/webstore/detail/cfhdojbkjhnklbpkdaibdccddilifddb",
+    "msie": "https://update.adblockplus.org/latest/adblockplusie.exe",
+    "msedge": "https://www.microsoft.com/store/p/adblock-plus/9nblggh4r9nz",
+    "firefox": "https://update.adblockplus.org/latest/adblockplusfirefox.xpi",
+    "safari": "https://update.adblockplus.org/latest/adblockplussafari.safariextz",
     "maxthon": "",
 
     // Mobile platforms
-    "ios": {
-      installer: "https://eyeo.to/adblockbrowser/ios/abp-website",

[saroyanm, 2018/03/23 19:08:37]

We might want to use this or similar redirection links in the download page I
assume, relevant ->
https://codereview.adblockplus.org/29722640/diff/29729581/pages/download.tmpl...

[ire, 2018/03/26 10:23:01]

Ack.

-      label: "iOS",
-    },
-    "android": {
-      installer: "https://eyeo.to/adblockbrowser/android/abp-website",
-      label: "Android"
-    }
+    "ios": "https://eyeo.to/adblockbrowser/ios/abp-website",
+    "android": "https://eyeo.to/adblockbrowser/android/abp-website"
   };
 
   function setupHeroDownloadButton()
   {
-    var heroDownloadButton = document.getElementById("hero-download-button");
-    var detectedPlatform;
-
-    for (var key in supportedPlatforms) if (bowser[key]) detectedPlatform = key;
+    var detectedPlatform = Object.keys(supportedPlatforms)
+      .find(bowser.hasOwnProperty.bind(bowser));
 
     if (!detectedPlatform) return;
 
     document.body.classList.add(detectedPlatform);
 
-    if (detectedPlatform === "maxthon") return;
+    if (detectedPlatform == "maxthon") return;
+
+    var heroDownloadButton = document.getElementById("hero-download-button");
+    heroDownloadButton.href = supportedPlatforms[detectedPlatform];
+    heroDownloadButton.textContent = document
+      .getElementById("download-label-" + detectedPlatform)
+      .textContent;
     
-    heroDownloadButton.href = supportedPlatforms[detectedPlatform].installer;
-    heroDownloadButton.textContent = document
-      .getElementById("hero-download-button-template")
-      .innerHTML
-      .replace("browser", supportedPlatforms[detectedPlatform].label);
+    heroDownloadButton.addEventListener("click", function(event)
+    {
+      if (typeof chrome == "undefined") return;
+      event.preventDefault();
+
+      try
+      {
+        chrome.webstore.install();
+      }
+      catch(error)
+      {
+        window.location = "/" + this.hreflang + "/download";
+      }
+    });
   }
 
-  if (bowser) setupHeroDownloadButton();
+  if (typeof bowser != "undefined") setupHeroDownloadButton();
 
 }());