Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: globals/browsers.py

Issue 29727563: Fixes #35 - Progressively enhance install button with appropriate links and text (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org
Left Patch Set: Addressed comments #7 Created April 5, 2018, 2:31 p.m.
Right Patch Set: Addressed comments #21 Created April 16, 2018, 4 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | includes/hero-download.html » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 # This file is part of the Adblock Plus website, 1 # This file is part of the Adblock Plus website,
2 # Copyright (C) 2006-present eyeo GmbH 2 # Copyright (C) 2006-present eyeo GmbH
3 # 3 #
4 # Adblock Plus is free software: you can redistribute it and/or modify 4 # Adblock Plus is free software: you can redistribute it and/or modify
5 # it under the terms of the GNU General Public License version 3 as 5 # it under the terms of the GNU General Public License version 3 as
6 # published by the Free Software Foundation. 6 # published by the Free Software Foundation.
7 # 7 #
8 # Adblock Plus is distributed in the hope that it will be useful, 8 # Adblock Plus is distributed in the hope that it will be useful,
9 # but WITHOUT ANY WARRANTY; without even the implied warranty of 9 # but WITHOUT ANY WARRANTY; without even the implied warranty of
10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 # GNU General Public License for more details. 11 # GNU General Public License for more details.
12 # 12 #
13 # You should have received a copy of the GNU General Public License 13 # You should have received a copy of the GNU General Public License
14 # along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 14 # along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
15 15
16 browsers = [ 16 browsers = [
ire 2018/04/05 14:32:44 TOL: This could be in website-defaults?
juliandoucette 2018/04/06 12:35:23 It could be. Not for adblockplus.org though (until
ire 2018/04/06 13:21:49 Do we need to change the deployment process to mak
17 { 17 {
18 'id': 'chrome', 18 'id': 'chrome',
19 'name': 'Chrome' 19 'name': 'Chrome'
20 }, 20 },
21 { 21 {
22 'id': 'firefox', 22 'id': 'firefox',
23 'name': 'Firefox' 23 'name': 'Firefox'
24 }, 24 },
25 { 25 {
26 'id': 'ios',
27 'name': 'iOS Safari'
28 },
29 {
30 'id': 'safari', 26 'id': 'safari',
31 'name': 'Safari' 27 'name': 'Safari'
32 }, 28 },
33 { 29 {
34 'id': 'msie', 30 'id': 'msie',
35 'name': 'Internet Explorer' 31 'name': 'Internet Explorer'
36 }, 32 },
37 { 33 {
38 'id': 'msedge', 34 'id': 'msedge',
39 'name': 'Microsoft Edge' 35 'name': 'Microsoft Edge'
40 }, 36 },
41 { 37 {
42 'id': 'opera', 38 'id': 'opera',
43 'name': 'Opera' 39 'name': 'Opera'
44 }, 40 },
45 { 41 {
46 'id': 'maxthon', 42 'id': 'maxthon',
47 'name': 'Maxthon' 43 'name': 'Maxthon'
48 }, 44 },
49 { 45 {
50 'id': 'samsungBrowser', 46 'id': 'yandexbrowser',
51 'name': 'Samsung Internet' 47 'name': 'Yandex.Browser'
52 }, 48 },
53 { 49 {
54 'id': 'yandexbrowser', 50 'id': 'ios',
55 'name': 'Yandex.Browser' 51 'name': 'iOS'
52 },
53 {
54 'id': 'android',
55 'name': 'Android'
56 } 56 }
57 ] 57 ]
LEFTRIGHT

Powered by Google App Engine
This is Rietveld