Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: includes/index.tmpl

Issue 29727563: Fixes #35 - Progressively enhance install button with appropriate links and text (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org
Left Patch Set: Addressed comments #10 Created April 6, 2018, 1:21 p.m.
Right Patch Set: Addressed comments #21 Created April 16, 2018, 4 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « includes/index.html ('k') | static/css/index.css » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 title=Adblock Plus | The world's # 1 free ad blocker 1 title=Adblock Plus | The world's # 1 free ad blocker
2 description=Adblock Plus, the most popular ad blocker on Firefox, Chrome, Safari , Android and iOS. Block pop-ups and annoying ads on websites like Facebook and YouTube. 2 description=Adblock Plus, the most popular ad blocker on Firefox, Chrome, Safari , Android and iOS. Block pop-ups and annoying ads on websites like Facebook and YouTube.
3 3
4 <head> 4 <head>
5 <link rel="stylesheet" href="/css/index.css"> 5 <link rel="stylesheet" href="/css/index.css">
6 <link rel="chrome-webstore-item" href="https://chrome.google.com/webstore/deta il/cfhdojbkjhnklbpkdaibdccddilifddb"> 6 <link rel="chrome-webstore-item" href="https://chrome.google.com/webstore/deta il/cfhdojbkjhnklbpkdaibdccddilifddb">
7 </head> 7 </head>
8 8
9 <? include hero-download ?> 9 <? include hero-download ?>
10 <? include as-mentioned ?> 10 <? include as-mentioned ?>
11 <? include features ?> 11 <? include features ?>
12 <? include abb-cross-promotion ?> 12 <? include abb-cross-promotion ?>
13 <? include footnote ?> 13 <? include footnote ?>
14 14
15 <script id="hero-download-button-template" type="text/template"> 15 {% for browser in browsers %}
juliandoucette 2018/04/06 16:29:16 I'm not certain that "Install for" should always c
ire 2018/04/09 09:24:01 Done.
juliandoucette 2018/04/09 13:01:02 You didn't say whether or not you determined my se
ire 2018/04/12 08:05:46 I didn't think it would be an issue since we would
juliandoucette 2018/04/16 11:46:37 From Tamara in the email thread "RE: translation o
16 <script id="download-label-{{ browser.id }}" type="text/template">
16 {% if locale in ["en", "de", "fr"] %} 17 {% if locale in ["en", "de", "fr"] %}
17 {{ "Agree and Install for" | translate("agree-and-install-for-browser", "but ton label") }} 18 {{ "Agree and Install for " + browser.name | translate("agree-and-install-fo r-" + browser.id, "button label") }}
18 {% else %} 19 {% else %}
19 {{ "Install for" | translate("install-for-browser", "button label") }} 20 {{ "Install for " + browser.name | translate("install-for-" + browser.id, "b utton label") }}
20 {% endif %} 21 {% endif %}
21 {% for browser in browsers %}
22 <span class="show-on-{{ browser.id }}">{{ browser.name | translate(browser.i d + "-name") }}</span>
23 {% endfor %}
24 </script> 22 </script>
23 {% endfor %}
25 24
26 <script src="/js/vendor/bowser.js"></script> 25 <script src="/js/vendor/bowser.js"></script>
27 <script src="/js/index.js"></script> 26 <script src="/js/index.js"></script>
LEFTRIGHT

Powered by Google App Engine
This is Rietveld