Delta Between Two Patch Sets: includes/index.tmpl
Issue 29727563:
Fixes #35 - Progressively enhance install button with appropriate links and text (Closed)
Base URL: https://hg.adblockplus.org/web.adblockplus.org
Left Patch Set: Addressed comments #12
Created April 9, 2018, 9:22 a.m.
Right Patch Set: Addressed comments #21
Created April 16, 2018, 4 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« includes/index.html ('k')
|
static/css/index.css » ('j')
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 title=Adblock Plus | The world's # 1 free ad blocker | 1 title=Adblock Plus | The world's # 1 free ad blocker |
| 2 description=Adblock Plus, the most popular ad blocker on Firefox, Chrome, Safari , Android and iOS. Block pop-ups and annoying ads on websites like Facebook and YouTube. | 2 description=Adblock Plus, the most popular ad blocker on Firefox, Chrome, Safari , Android and iOS. Block pop-ups and annoying ads on websites like Facebook and YouTube. |
| 3 | 3 |
| 4 <head> | 4 <head> |
| 5 <link rel="stylesheet" href="/css/index.css"> | 5 <link rel="stylesheet" href="/css/index.css"> |
| 6 <link rel="chrome-webstore-item" href="https://chrome.google.com/webstore/deta il/cfhdojbkjhnklbpkdaibdccddilifddb"> | 6 <link rel="chrome-webstore-item" href="https://chrome.google.com/webstore/deta il/cfhdojbkjhnklbpkdaibdccddilifddb"> |
| 7 </head> | 7 </head> |
| 8 | 8 |
| 9 <? include hero-download ?> | 9 <? include hero-download ?> |
| 10 <? include as-mentioned ?> | 10 <? include as-mentioned ?> |
| 11 <? include features ?> | 11 <? include features ?> |
| 12 <? include abb-cross-promotion ?> | 12 <? include abb-cross-promotion ?> |
| 13 <? include footnote ?> | 13 <? include footnote ?> |
| 14 | 14 |
| 15 <script id="hero-download-button-template" type="text/template"> | 15 {% for browser in browsers %} |
|
juliandoucette
2018/04/09 13:01:02
NIT: I'd prefer to output translations into a sing
ire
2018/04/12 08:05:46
Ack, I think we can handle this separately then.
| |
| 16 <script id="download-label-{{ browser.id }}" type="text/template"> | |
| 16 {% if locale in ["en", "de", "fr"] %} | 17 {% if locale in ["en", "de", "fr"] %} |
| 17 {{ "Agree and Install for <fix>browser</fix>" | translate("agree-and-install -for-browser", "button label") }} | 18 {{ "Agree and Install for " + browser.name | translate("agree-and-install-fo r-" + browser.id, "button label") }} |
| 18 {% else %} | 19 {% else %} |
| 19 {{ "Install for <fix>browser</fix>" | translate("install-for-browser", "butt on label") }} | 20 {{ "Install for " + browser.name | translate("install-for-" + browser.id, "b utton label") }} |
| 20 {% endif %} | 21 {% endif %} |
| 21 </script> | 22 </script> |
| 22 | |
| 23 {% for browser in browsers %} | |
| 24 <script id="{{ browser.id }}-name-translated" type="text/template"> | |
| 25 {{ browser.name | translate(browser.id + "-name") }} | |
| 26 </script> | |
| 27 {% endfor %} | 23 {% endfor %} |
| 28 | 24 |
| 29 <script src="/js/vendor/bowser.js"></script> | 25 <script src="/js/vendor/bowser.js"></script> |
| 30 <script src="/js/index.js"></script> | 26 <script src="/js/index.js"></script> |
| LEFT | RIGHT |
« includes/index.html ('k')
|
static/css/index.css » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
