Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: static/js/index.js

Issue 29727563: Fixes #35 - Progressively enhance install button with appropriate links and text (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org
Left Patch Set: Change translation strings Created April 16, 2018, 3:06 p.m.
Right Patch Set: Addressed comments #21 Created April 16, 2018, 4 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « static/css/index.css ('k') | static/js/vendor/bowser.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 "use strict"; 1 "use strict";
2 2
3 (function() 3 (function()
4 { 4 {
5 var supportedPlatforms = { 5 var supportedPlatforms = {
6 6
7 // Desktop browsers 7 // Desktop browsers
8 "chrome": "https://chrome.google.com/webstore/detail/cfhdojbkjhnklbpkdaibdcc ddilifddb", 8 "chrome": "https://chrome.google.com/webstore/detail/cfhdojbkjhnklbpkdaibdcc ddilifddb",
9 "opera": "https://addons.opera.com/extensions/details/opera-adblock/?display =en-US", 9 "opera": "https://addons.opera.com/extensions/details/opera-adblock/?display =en-US",
10 "yandexbrowser": "https://chrome.google.com/webstore/detail/cfhdojbkjhnklbpk daibdccddilifddb", 10 "yandexbrowser": "https://chrome.google.com/webstore/detail/cfhdojbkjhnklbpk daibdccddilifddb",
(...skipping 14 matching lines...) Expand all
25 .find(bowser.hasOwnProperty.bind(bowser)); 25 .find(bowser.hasOwnProperty.bind(bowser));
26 26
27 if (!detectedPlatform) return; 27 if (!detectedPlatform) return;
28 28
29 document.body.classList.add(detectedPlatform); 29 document.body.classList.add(detectedPlatform);
30 30
31 if (detectedPlatform == "maxthon") return; 31 if (detectedPlatform == "maxthon") return;
32 32
33 var heroDownloadButton = document.getElementById("hero-download-button"); 33 var heroDownloadButton = document.getElementById("hero-download-button");
34 heroDownloadButton.href = supportedPlatforms[detectedPlatform]; 34 heroDownloadButton.href = supportedPlatforms[detectedPlatform];
35 heroDownloadButton.innerHTML = document 35 heroDownloadButton.textContent = document
juliandoucette 2018/04/16 15:44:41 NIT/Suggest: innerText (we don't support IE 8 anym
ire 2018/04/16 16:00:59 Changed to textContent which seems to be better fo
juliandoucette 2018/04/16 16:12:58 Thanks! (Facepalm: I meant to say textContent. My
36 .getElementById("hero-download-button-template-" + detectedPlatform) 36 .getElementById("download-label-" + detectedPlatform)
37 .innerHTML; 37 .textContent;
38 38
39 heroDownloadButton.addEventListener("click", function(event) 39 heroDownloadButton.addEventListener("click", function(event)
40 { 40 {
41 if (typeof chrome == "undefined") return; 41 if (typeof chrome == "undefined") return;
42 event.preventDefault(); 42 event.preventDefault();
43 43
44 try 44 try
juliandoucette 2018/04/16 15:44:41 TOL: Why are curly braces required for try/catch s
ire 2018/04/16 16:00:59 I know right?!?! Maybe there's a good reason I don
45 { 45 {
46 chrome.webstore.install(); 46 chrome.webstore.install();
47 } 47 }
48 catch(error) 48 catch(error)
49 { 49 {
50 window.location = "/" + this.hreflang + "/download"; 50 window.location = "/" + this.hreflang + "/download";
51 } 51 }
52 }); 52 });
53 } 53 }
54 54
55 if (typeof bowser != "undefined") setupHeroDownloadButton(); 55 if (typeof bowser != "undefined") setupHeroDownloadButton();
56 56
57 }()); 57 }());
LEFTRIGHT

Powered by Google App Engine
This is Rietveld