Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: includes/index.tmpl

Issue 29727563: Fixes #35 - Progressively enhance install button with appropriate links and text (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org
Patch Set: Addressed comments #10 Created April 6, 2018, 1:21 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « includes/index.html ('k') | static/css/index.css » ('j') | static/js/index.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: includes/index.tmpl
===================================================================
new file mode 100644
--- /dev/null
+++ b/includes/index.tmpl
@@ -0,0 +1,27 @@
+title=Adblock Plus | The world's # 1 free ad blocker
+description=Adblock Plus, the most popular ad blocker on Firefox, Chrome, Safari, Android and iOS. Block pop-ups and annoying ads on websites like Facebook and YouTube.
+
+<head>
+ <link rel="stylesheet" href="/css/index.css">
+ <link rel="chrome-webstore-item" href="https://chrome.google.com/webstore/detail/cfhdojbkjhnklbpkdaibdccddilifddb">
+</head>
+
+<? include hero-download ?>
+<? include as-mentioned ?>
+<? include features ?>
+<? include abb-cross-promotion ?>
+<? include footnote ?>
+
+<script id="hero-download-button-template" type="text/template">
juliandoucette 2018/04/06 16:29:16 I'm not certain that "Install for" should always c
ire 2018/04/09 09:24:01 Done.
juliandoucette 2018/04/09 13:01:02 You didn't say whether or not you determined my se
ire 2018/04/12 08:05:46 I didn't think it would be an issue since we would
juliandoucette 2018/04/16 11:46:37 From Tamara in the email thread "RE: translation o
+ {% if locale in ["en", "de", "fr"] %}
+ {{ "Agree and Install for" | translate("agree-and-install-for-browser", "button label") }}
+ {% else %}
+ {{ "Install for" | translate("install-for-browser", "button label") }}
+ {% endif %}
+ {% for browser in browsers %}
+ <span class="show-on-{{ browser.id }}">{{ browser.name | translate(browser.id + "-name") }}</span>
+ {% endfor %}
+</script>
+
+<script src="/js/vendor/bowser.js"></script>
+<script src="/js/index.js"></script>
« no previous file with comments | « includes/index.html ('k') | static/css/index.css » ('j') | static/js/index.js » ('J')

Powered by Google App Engine
This is Rietveld