Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(478)

Issue 29727587: Issue 6500 - Update libadblockplus dependency to revision hg:05a7fb3c0c61 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years ago by anton
Modified:
2 years ago
CC:
sergei
Visibility:
Public.

Description

Issue 6500 - Update libadblockplus dependency to revision hg:05a7fb3c0c61

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed double increased numbers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M dependencies View 1 chunk +1 line, -1 line 0 comments Download
M libadblockplus-android-webview/build.gradle View 1 1 chunk +2 lines, -2 lines 0 comments Download
M libadblockplus-android-webviewapp/build.gradle View 1 chunk +2 lines, -2 lines 0 comments Download
M libadblockplus-android/build.gradle View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6
anton
2 years ago (2018-03-19 14:01:07 UTC) #1
diegocarloslima
https://codereview.adblockplus.org/29727587/diff/29727588/libadblockplus-android-webview/build.gradle File libadblockplus-android-webview/build.gradle (right): https://codereview.adblockplus.org/29727587/diff/29727588/libadblockplus-android-webview/build.gradle#newcode11 libadblockplus-android-webview/build.gradle:11: versionName "2.3" why are we bumping 2 versions here?
2 years ago (2018-03-20 12:53:54 UTC) #2
anton
https://codereview.adblockplus.org/29727587/diff/29727588/libadblockplus-android-webview/build.gradle File libadblockplus-android-webview/build.gradle (right): https://codereview.adblockplus.org/29727587/diff/29727588/libadblockplus-android-webview/build.gradle#newcode11 libadblockplus-android-webview/build.gradle:11: versionName "2.3" On 2018/03/20 12:53:53, diegocarloslima wrote: > why ...
2 years ago (2018-03-20 12:56:04 UTC) #3
anton
On 2018/03/20 12:56:04, anton wrote: > https://codereview.adblockplus.org/29727587/diff/29727588/libadblockplus-android-webview/build.gradle > File libadblockplus-android-webview/build.gradle (right): > > https://codereview.adblockplus.org/29727587/diff/29727588/libadblockplus-android-webview/build.gradle#newcode11 > ...
2 years ago (2018-03-20 12:57:47 UTC) #4
diegocarloslima
On 2018/03/20 12:57:47, anton wrote: > On 2018/03/20 12:56:04, anton wrote: > > > https://codereview.adblockplus.org/29727587/diff/29727588/libadblockplus-android-webview/build.gradle ...
2 years ago (2018-03-20 13:02:47 UTC) #5
René Jeschke
2 years ago (2018-03-20 13:34:27 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5