Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(635)

Issue 29728579: Issue 6437 - Apply :-abp-contains() to matching roots only (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months ago by Manish Jethani
Modified:
5 months ago
Reviewers:
hub
CC:
kzar, sergei
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

For a filter like div:-abp-contains(Hello) and a subtree like <div id="a"><div id="b"><div id="c">Hello</div></div></div> we're only interested in div#a

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Update tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M lib/content/elemHideEmulation.js View 1 1 chunk +13 lines, -0 lines 0 comments Download
M test/browser/elemHideEmulation.js View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8
Manish Jethani
6 months ago (2018-03-20 10:41:36 UTC) #1
hub
this warrant updating the test suite.
5 months, 2 weeks ago (2018-04-08 11:24:47 UTC) #2
hub
And actually the behaviour we want is only getting div#c (the strictest match)
5 months, 2 weeks ago (2018-04-08 11:26:25 UTC) #3
Manish Jethani
On 2018/04/08 11:26:25, hub wrote: > And actually the behaviour we want is only getting ...
5 months, 2 weeks ago (2018-04-08 12:09:48 UTC) #4
hub
On 2018/04/08 12:09:48, Manish Jethani wrote: > On 2018/04/08 11:26:25, hub wrote: > > And ...
5 months, 1 week ago (2018-04-09 03:32:47 UTC) #5
Manish Jethani
Patch Set 2: Rebase Patch Set 3: Update tests The updated tests cover the change ...
5 months ago (2018-04-19 16:29:10 UTC) #6
Manish Jethani
On 2018/04/09 03:32:47, hub wrote: > On 2018/04/08 12:09:48, Manish Jethani wrote: > > On ...
5 months ago (2018-04-19 16:29:41 UTC) #7
hub
5 months ago (2018-04-19 18:46:28 UTC) #8
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5