Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29728690: Issue 6504, 6458, 6446 - Update selectors based on DOM mutations (Closed)

Created:
March 21, 2018, 4:29 a.m. by Manish Jethani
Modified:
March 19, 2019, 8:21 a.m.
Reviewers:
CC:
kzar, hub
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Total comments: 5

Patch Set 2 : Spelling correction #

Patch Set 3 : Encapsulate selector management in CSSSelectorManager class #

Patch Set 4 : Add special case check for documents with no extended selectors #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -3 lines) Patch
M lib/content/elemHideEmulation.js View 1 2 3 5 chunks +171 lines, -3 lines 3 comments Download

Messages

Total messages: 7
Manish Jethani
March 21, 2018, 4:29 a.m. (2018-03-21 04:29:41 UTC) #1
Manish Jethani
Patch Set 1 Patch Set 2: Spelling correction Now that we are using CSS selectors ...
March 21, 2018, 4:45 a.m. (2018-03-21 04:45:45 UTC) #2
Manish Jethani
Patch Set 3: Encapsulate selector management in CSSSelectorManager class Patch Set 4: Add special case ...
March 21, 2018, 3:35 p.m. (2018-03-21 15:35:26 UTC) #3
hub
https://codereview.adblockplus.org/29728690/diff/29729629/lib/content/elemHideEmulation.js File lib/content/elemHideEmulation.js (right): https://codereview.adblockplus.org/29728690/diff/29729629/lib/content/elemHideEmulation.js#newcode953 lib/content/elemHideEmulation.js:953: this.addSelectorsFunc(this.css.selectors, this.css.filters); My concern here is that the intent ...
March 23, 2018, 3:54 p.m. (2018-03-23 15:54:26 UTC) #4
Manish Jethani
https://codereview.adblockplus.org/29728690/diff/29729629/lib/content/elemHideEmulation.js File lib/content/elemHideEmulation.js (right): https://codereview.adblockplus.org/29728690/diff/29729629/lib/content/elemHideEmulation.js#newcode953 lib/content/elemHideEmulation.js:953: this.addSelectorsFunc(this.css.selectors, this.css.filters); On 2018/03/23 15:54:25, hub wrote: > My ...
March 23, 2018, 4:55 p.m. (2018-03-23 16:55:33 UTC) #5
Manish Jethani
This also affects Trac #6446, I have updated the summary.
June 12, 2018, 8:03 a.m. (2018-06-12 08:03:18 UTC) #6
Manish Jethani
March 19, 2019, 8:21 a.m. (2019-03-19 08:21:30 UTC) #7
Since we decided not to use style sheets for element hiding emulation [1], this
change no longer makes sense.

I'm closing this.

[1]: https://issues.adblockplus.org/ticket/6504#Resolution

Powered by Google App Engine
This is Rietveld