Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(333)

Issue 29728690: Issue 6504, 6458, 6446 - Update selectors based on DOM mutations

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months ago by Manish Jethani
Modified:
2 months, 1 week ago
Reviewers:
CC:
kzar, hub
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Total comments: 5

Patch Set 2 : Spelling correction #

Patch Set 3 : Encapsulate selector management in CSSSelectorManager class #

Patch Set 4 : Add special case check for documents with no extended selectors #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -3 lines) Patch
M lib/content/elemHideEmulation.js View 1 2 3 5 chunks +171 lines, -3 lines 3 comments Download

Messages

Total messages: 6
Manish Jethani
7 months ago (2018-03-21 04:29:41 UTC) #1
Manish Jethani
Patch Set 1 Patch Set 2: Spelling correction Now that we are using CSS selectors ...
7 months ago (2018-03-21 04:45:45 UTC) #2
Manish Jethani
Patch Set 3: Encapsulate selector management in CSSSelectorManager class Patch Set 4: Add special case ...
7 months ago (2018-03-21 15:35:26 UTC) #3
hub
https://codereview.adblockplus.org/29728690/diff/29729629/lib/content/elemHideEmulation.js File lib/content/elemHideEmulation.js (right): https://codereview.adblockplus.org/29728690/diff/29729629/lib/content/elemHideEmulation.js#newcode953 lib/content/elemHideEmulation.js:953: this.addSelectorsFunc(this.css.selectors, this.css.filters); My concern here is that the intent ...
7 months ago (2018-03-23 15:54:26 UTC) #4
Manish Jethani
https://codereview.adblockplus.org/29728690/diff/29729629/lib/content/elemHideEmulation.js File lib/content/elemHideEmulation.js (right): https://codereview.adblockplus.org/29728690/diff/29729629/lib/content/elemHideEmulation.js#newcode953 lib/content/elemHideEmulation.js:953: this.addSelectorsFunc(this.css.selectors, this.css.filters); On 2018/03/23 15:54:25, hub wrote: > My ...
7 months ago (2018-03-23 16:55:33 UTC) #5
Manish Jethani
4 months, 1 week ago (2018-06-12 08:03:18 UTC) #6
This also affects Trac #6446, I have updated the summary.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5