lib/filterNotifier.js - Issue 29729594: Noissue - Use Map to store EventEmitter listeners

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: lib/filterNotifier.js

Issue 29729594: Noissue - Use Map to store EventEmitter listeners (Closed)

Patch Set: Avoid calling .get directly after .has Created April 3, 2018, 5:26 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: lib/filterNotifier.js

diff --git a/lib/filterNotifier.js b/lib/filterNotifier.js

index 15d9fe9afd5f7067a47b2ae3760f83e6bacc2bbb..00f4d5861400287d0e99c99fc38f08cc2964bfc0 100644

--- a/lib/filterNotifier.js

+++ b/lib/filterNotifier.js

@@ -47,7 +47,7 @@ exports.FilterNotifier = Object.create(new EventEmitter(), desc({

addListener(listener)

{

- let listeners = this._listeners[CATCH_ALL];

+ let listeners = this._listeners.get(CATCH_ALL);

if (!listeners || listeners.indexOf(listener) == -1)

this.on(CATCH_ALL, listener);

« no previous file with comments | « lib/events.js ('k') | no next file » | no next file with comments »