Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: sitescripts/extensions/bin/createNightlies.py

Issue 29730555: Noissue - don't fail on non-existent lockfile (Closed) Base URL: https://hg.adblockplus.org/abpssembly/file/93c8f5ecd4b1
Patch Set: Created March 22, 2018, 8:29 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sitescripts/extensions/bin/createNightlies.py
diff --git a/sitescripts/extensions/bin/createNightlies.py b/sitescripts/extensions/bin/createNightlies.py
index a2ee31943bc2c35a0c55ced89bf21eed614400b1..f8011b8db28ab612f91ef87fb1dc51c8ad1810d4 100644
--- a/sitescripts/extensions/bin/createNightlies.py
+++ b/sitescripts/extensions/bin/createNightlies.py
@@ -426,7 +426,7 @@ class NightlyBuild(object):
with open(path, 'r') as fp:
current = json.load(fp)
except IOError:
- logging.warning('No lockfile found. Creating ' + path)
+ logging.debug('No lockfile found at ' + path)
current = {}
return current
@@ -823,9 +823,7 @@ class NightlyBuild(object):
shutil.rmtree(self.tempdir, ignore_errors=True)
def download(self):
- with open(get_config().get('extensions', 'downloadLockFile')) as fp:
- download_info = json.load(fp)
-
+ download_info = self.read_downloads_lockfile()
downloads = self.downloadable_repos.intersection(download_info.keys())
if self.config.type in downloads:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld