Issue 6511 - Use messaging to register popup notification clicks

metadata.chrome

 [general]
 basename = adblockpluschrome
 version = 3.0.2
 author = eyeo GmbH
 permissions = tabs
   <all_urls>
   contextMenus
   webRequest
   webRequestBlocking
   webNavigation
@@ skipping 94 matching lines @@
 skin/updates/icon-mobile.svg = adblockplusui/skin/updates/icon-mobile.svg
 skin/updates/icon-rocket.svg = adblockplusui/skin/updates/icon-rocket.svg
 skin/updates/icon-thumbs-up.svg = adblockplusui/skin/updates/icon-thumbs-up.svg
 devtools-panel.html = adblockplusui/devtools-panel.html
 devtools-panel.js = adblockplusui/devtools-panel.js
 skin/devtools-panel.css = adblockplusui/skin/devtools-panel.css
 issue-reporter.html = adblockplusui/issue-reporter.html
 issue-reporter.js = adblockplusui/issue-reporter.js
 skin/issue-reporter.css = adblockplusui/skin/issue-reporter.css
 desktop-options.html = adblockplusui/desktop-options.html
-desktop-options.js = adblockplusui/desktop-options.js
+desktop-options.js = adblockplusui/js/desktop-options.js

[saroyanm, 2018/03/22 17:30:47]

No need to update the path of desktop-options.js we did introduce modularization
 in #6310, so the generated desktop-options.js be
`adblockplusui/desktop-options.js` 

[kzar, 2018/03/22 17:36:50]

Well so far there is no adblockplusui/desktop-options.js file, and now no
desktop-options.css file either. The issue #6310 provides zero integration notes
and hardly any information for me to understand how any of this is supposed to
work.

So I will update this codereview once the adblockplusui dependency got updated
by someone else, but until then I'll leave this path as
adblockplusui/js/desktop-options.js so that I can test that my changes work.

[saroyanm, 2018/03/22 18:03:19]

Right, the information is in the README file ->
https://hg.adblockplus.org/adblockplusui/file/tip/README.md#l100 and 
https://hg.adblockplus.org/adblockplusui/file/tip/README.md#l36
The file is generated during the build process, alternatively you can build it
manually by running `npm i` inside of adblockplusui, hope this helps.

[a.giammarchi, 2018/03/23 14:24:56]

As previously discussed, and as mentioned by Manvel, this will break.

We are bundling that file, producing exactly what you expect, which is
`adblockplusui/desktop-options.js`

Please revert this change or we'll have more issues, thanks.

[kzar, 2018/03/23 14:43:11]

As I mentioned I will update this codereview once the dependency update (#6476)
has landed.

 skin/desktop-options.css = adblockplusui/skin/desktop-options.css
 updates.html = adblockplusui/updates.html
 updates.js = adblockplusui/updates.js
 skin/updates.css = adblockplusui/skin/updates.css
 
 [bundles]
 lib/adblockplus.js =
   adblockpluscore/lib/filterListener.js
   adblockpluscore/lib/synchronizer.js
   lib/requestBlocker.js
@@ skipping 14 matching lines @@
   qunit/tests/url.js
   qunit/tests/cssEscaping.js
 
 [import_locales]
 adblockplusui/locale/*/antiadblockInit.json = *
 adblockplusui/locale/*/common.json = *
 adblockplusui/locale/*/desktop-options.json = *
 adblockplusui/locale/*/firstRun.json = *
 adblockplusui/locale/*/issue-reporter.json = *
 adblockplusui/locale/*/updates.json = *