Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1032)

Issue 29730617: Issue 6510 - Configure notification opens options page incorrectly (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 7 months ago by saroyanm
Modified:
1 year, 7 months ago
Reviewers:
a.giammarchi
CC:
kzar
Visibility:
Public.

Description

Issue 6510 - Configure notification opens options page incorrectly

Patch Set 1 : #

Total comments: 11

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -2 lines) Patch
M css/desktop-options.scss View 1 1 chunk +17 lines, -0 lines 0 comments Download
M js/desktop-options.js View 1 2 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 5
saroyanm
Andrea can you please have a look
1 year, 7 months ago (2018-03-22 16:12:45 UTC) #1
saroyanm
https://codereview.adblockplus.org/29730617/diff/29730627/js/desktop-options.js File js/desktop-options.js (right): https://codereview.adblockplus.org/29730617/diff/29730627/js/desktop-options.js#newcode1459 js/desktop-options.js:1459: case "focusSection": We used to set the tab view ...
1 year, 7 months ago (2018-03-22 16:15:53 UTC) #2
a.giammarchi
nothing crucial, nothing a real blocker, but I have few questions before moving forward. https://codereview.adblockplus.org/29730617/diff/29730627/css/desktop-options.scss ...
1 year, 7 months ago (2018-03-22 18:43:28 UTC) #3
saroyanm
Thanks for review Andrea, otherwise wouldn't be easy to move this forward as Thomas is ...
1 year, 7 months ago (2018-03-22 20:43:22 UTC) #4
a.giammarchi
1 year, 7 months ago (2018-03-22 22:51:29 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5