Unified Diff: tests/io-toggle.html
Issue 29730644:
Issue 6514 - IOToggle Custom Element (Closed)
Patch Set:
Created March 26, 2018, 2:24 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« js/io-toggle.js ('K')
|
« package.json ('k')
|
tests/io-toggle.js » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: tests/io-toggle.html |
| =================================================================== |
| new file mode 100644 |
| --- /dev/null |
| +++ b/tests/io-toggle.html |
| @@ -0,0 +1,30 @@ |
| +<!DOCTYPE html> |
| +<html> |
| + <head> |
| + <meta charset="utf-8"> |
| + <title>Test io-toggle.js</title> |
| + <link rel="stylesheet" href="../skin/common.css"> |
|
saroyanm
2018/04/25 17:05:01
Seems like The toggle buttons are not dependent on
a.giammarchi
2018/04/26 10:44:52
it is mandatory to test components UI together wit
Thomas Greiner
2018/04/26 17:00:52
Acknowledged.
a.giammarchi
2018/04/27 10:59:05
I forgot to answer this Manvel point. The `IOEleme
|
| + <link rel="stylesheet" href="../skin/fonts.css"> |
| + <link rel="stylesheet" href="../skin/desktop-options.css"> |
| + <style> |
|
Thomas Greiner
2018/04/25 17:29:14
I know that it's just a test but I think it'd be b
a.giammarchi
2018/04/26 10:44:52
If we make writing tests hard, we'll most likely w
Thomas Greiner
2018/04/26 17:00:52
While it sounds reasonable at first glance, I'm no
a.giammarchi
2018/04/27 10:59:05
I am not saying tests should not be reviewed, I am
Thomas Greiner
2018/05/02 11:53:28
I think we agree on all points and just need to ag
|
| + fieldset { |
| + margin: 4px; |
| + padding: 8px; |
| + border: 1px solid silver; |
| + line-height: 0; |
| + } |
| + </style> |
| + <script defer src="../polyfill.js"></script> |
| + <script defer src="../ext/common.js"></script> |
| + <script defer src="../ext/content.js"></script> |
| + <script defer src="../common.js"></script> |
| + <script defer src="../i18n.js"></script> |
| + <script defer src="./io-toggle.js"></script> |
| + </head> |
| + <body style="background:white;"> |
| + <fieldset><io-toggle onchange="console.log(event)"></io-toggle></fieldset> |
|
saroyanm
2018/04/25 17:05:01
Suggestion: I suggest not include console.logs in
a.giammarchi
2018/04/26 10:44:52
fair enough, but please consider my answer to Thom
|
| + <fieldset><io-toggle checked></io-toggle></fieldset> |
| + <fieldset><io-toggle disabled></io-toggle></fieldset> |
| + <fieldset><io-toggle checked disabled></io-toggle></fieldset> |
| + </body> |
| +</html> |
« js/io-toggle.js ('K')
|
« package.json ('k')
|
tests/io-toggle.js » ('j')
|
no next file with comments »
