Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: dependencies

Issue 29730656: Issue 6476 - Update adblockplusui dependencies to ead38c2013b5 (Closed)
Patch Set: Created March 22, 2018, 8:45 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/notificationHelper.js » ('j') | lib/options.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dependencies
===================================================================
--- a/dependencies
+++ b/dependencies
@@ -1,5 +1,5 @@
_root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/
_self = buildtools/ensure_dependencies.py
buildtools = buildtools hg:c830dfa08e2f git:3a925dd
adblockpluscore = adblockpluscore hg:69a1ff0e91b3 git:a902e17
-adblockplusui = adblockplusui hg:08bd84805764 git:93b2850
+adblockplusui = adblockplusui hg:12c59fe0fa0a git:93b2850
kzar 2018/03/23 11:04:32 Please instead update the dependency to ead38c2013
saroyanm 2018/03/23 11:26:47 I was thinking to push this -> https://codereview.
kzar 2018/03/23 11:30:03 I will need to make some further changes to adbloc
saroyanm 2018/03/23 12:03:17 Noted, I've pushed 6510 and did some tests, as it
kzar 2018/03/23 12:10:38 Please could you update the dependency to ead38c20
saroyanm 2018/03/23 12:15:49 Sorry I think I had missunderstood you, done.
kzar 2018/03/23 13:09:39 That's OK, but please could you update the Git rev
saroyanm 2018/03/23 14:38:39 It should be updated -> https://codereview.adblock
kzar 2018/03/23 14:50:23 Well so far the the adblockplusui dependency is be
saroyanm 2018/03/23 15:02:10 OOps, sorry for that I used the revision for your
« no previous file with comments | « no previous file | lib/notificationHelper.js » ('j') | lib/options.js » ('J')

Powered by Google App Engine
This is Rietveld