Issue 6523 - Update softlink for downloaded builds

sitescripts/extensions/bin/createNightlies.py

 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-present eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
@@ skipping 527 matching lines @@
         config = get_config()
         iss = config.get('extensions', 'amo_key')
         secret = config.get('extensions', 'amo_secret')
 
         url = ('https://addons.mozilla.org/api/v3/addons/{}/'
                'versions/{}/').format(app_id, version)
 
         request = self.generate_jwt_request(iss, secret, url, 'GET')
         response = json.load(urllib2.urlopen(request))
 
+        filename = '{}-{}.xpi'.format(self.basename, version)
+        self.path = os.path.join(
+            config.get('extensions', 'nightliesDirectory'),
+            self.basename,
+            filename
+        )
+
         necessary = ['passed_review', 'reviewed', 'processed', 'valid']
         if all(response[x] for x in necessary):
             download_url = response['files'][0]['download_url']
             checksum = response['files'][0]['hash']
-
-            filename = '{}-{}.xpi'.format(self.basename, version)
-            self.path = os.path.join(
-                config.get('extensions', 'nightliesDirectory'),
-                self.basename,
-                filename
-            )
 
             request = self.generate_jwt_request(iss, secret, download_url,
                                                 'GET')
             try:
                 response = urllib2.urlopen(request)
             except urllib2.HTTPError as e:
                 logging.error(e.read())
 
             # Verify the extension's integrity
             file_content = response.read()
@@ skipping 259 matching lines @@
 
         if self.config.type in downloads:
             try:
                 self.copyRepository()
                 self.readGeckoMetadata()
 
                 for data in download_info[self.config.type]:
                     self.version = data['version']
 
                     self.download_from_mozilla_addons(**data)
-
-                    # write out changelog
-                    self.writeChangelog(self.getChanges())
-
-                    # write update manifest
-                    self.writeUpdateManifest()
-
-                    # retire old builds
-                    versions = self.retireBuilds()
-                    # update index page
-                    self.updateIndex(versions)
-
-                    # Update soft link to latest build
-                    baseDir = os.path.join(
-                        self.config.nightliesDirectory, self.basename
-                    )
-                    linkPath = os.path.join(
-                        baseDir, '00latest' + self.config.packageSuffix
-                    )
-
-                    self.symlink_or_copy(self.path, linkPath)

[Vasily Kuznetsov, 2018/03/26 19:12:11]

What if we don't have `self.path` because in `download_from_mozilla_addons` we
followed the `else` branch of the `if` statement at line 549?

-
+                    if os.path.exists(self.path):
+                        # write out changelog
+                        self.writeChangelog(self.getChanges())
+
+                        # write update manifest
+                        self.writeUpdateManifest()
+
+                        # retire old builds
+                        versions = self.retireBuilds()
+                        # update index page
+                        self.updateIndex(versions)
+
+                        # Update soft link to latest build
+                        baseDir = os.path.join(
+                            self.config.nightliesDirectory, self.basename
+                        )
+                        linkPath = os.path.join(
+                            baseDir, '00latest' + self.config.packageSuffix
+                        )
+
+                        self.symlink_or_copy(self.path, linkPath)
             finally:
                 # clean up
                 if self.tempdir:
                     shutil.rmtree(self.tempdir, ignore_errors=True)
 
 
 def main(download=False):
     """
       main function for createNightlies.py
     """
@@ skipping 20 matching lines @@
 
     file = open(nightlyConfigFile, 'wb')
     nightlyConfig.write(file)
 
 
 if __name__ == '__main__':
     parser = argparse.ArgumentParser()
     parser.add_argument('--download', action='store_true', default=False)
     args = parser.parse_args()
     main(args.download)