Issue 6523 - Update softlink for downloaded builds

sitescripts/extensions/bin/createNightlies.py

Index: sitescripts/extensions/bin/createNightlies.py
diff --git a/sitescripts/extensions/bin/createNightlies.py b/sitescripts/extensions/bin/createNightlies.py
index f8011b8db28ab612f91ef87fb1dc51c8ad1810d4..077c0a31be8582ccbf9b4469a46b0583811656bc 100644
--- a/sitescripts/extensions/bin/createNightlies.py
+++ b/sitescripts/extensions/bin/createNightlies.py
@@ -551,7 +551,7 @@ class NightlyBuild(object):
             checksum = response['files'][0]['hash']
 
             filename = '{}-{}.xpi'.format(self.basename, version)
-            file_path = os.path.join(
+            self.path = os.path.join(
                 config.get('extensions', 'nightliesDirectory'),
                 self.basename,
                 filename
@@ -573,7 +573,7 @@ class NightlyBuild(object):
                 logging.error('Checksum could not be verified: {} vs {}'
                               ''.format(checksum, returned_checksum))
 
-            with open(file_path, 'w') as fp:
+            with open(self.path, 'w') as fp:
                 fp.write(file_content)
 
             self.update_link = os.path.join(
@@ -846,6 +846,17 @@ class NightlyBuild(object):
                     versions = self.retireBuilds()
                     # update index page
                     self.updateIndex(versions)
+
+                    # Update soft link to latest build
+                    baseDir = os.path.join(
+                        self.config.nightliesDirectory, self.basename
+                    )
+                    linkPath = os.path.join(
+                        baseDir, '00latest' + self.config.packageSuffix
+                    )
+
+                    self.symlink_or_copy(self.path, linkPath)

[Vasily Kuznetsov, 2018/03/26 19:12:11]

What if we don't have `self.path` because in `download_from_mozilla_addons` we
followed the `else` branch of the `if` statement at line 549?

+
             finally:
                 # clean up
                 if self.tempdir: