Issue 6396 - Error creating non debug build config

gni/v8.gni

Index: gni/v8.gni
diff --git a/gni/v8.gni b/gni/v8.gni
index 0467720f456680db76c765b6f57a9f45354c8197..ec61ea5536f36bf2f734b8ad565a59299872034d 100644
--- a/gni/v8.gni
+++ b/gni/v8.gni
@@ -45,6 +45,9 @@ declare_args() {
 
   # Use static libraries instead of source_sets.
   v8_static_library = false
+
+  # we need to have libv8.cr.so and some other shared libraries to link libadblockplus-android.so
+  v8_component_build = false
 }
 
 if (v8_use_external_startup_data == "") {
@@ -167,10 +170,32 @@ template("v8_executable") {
 }
 
 template("v8_component") {
-  component(target_name) {
-    forward_variables_from(invoker, "*", [ "configs" ])
-    configs += invoker.configs
-    configs -= v8_remove_configs
-    configs += v8_add_configs
+
+  if (defined(invoker.force_shared_library) && invoker.force_shared_library) {
+    shared_library(target_name) {
+      output_extension = "cr.so" # in order to load this app V8 shared library, not system one

[diegocarloslima, 2018/04/11 15:56:35]

I would just suggest to put this comment above the code instead of on its side

+      forward_variables_from(invoker, "*", [ "configs" ])
+      configs += invoker.configs
+      configs -= v8_remove_configs
+      configs += v8_add_configs
+
+      if (is_android) {
+        configs -= [ "//build/config/android:hide_all_but_jni_onload" ]
+      }
+
+      if (!defined(deps)) {
+        deps = []
+      }
+
+      deps += [ "//build/config:exe_and_shlib_deps" ]
+    }
+  } else {
+    component(target_name) {
+      forward_variables_from(invoker, "*", [ "configs" ])
+      configs += invoker.configs
+      configs -= v8_remove_configs
+      configs += v8_add_configs
+    }
   }
+
 }