Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(45)

Issue 29733731: #7320 - Introduce helpcenter role (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 weeks, 1 day ago by f.lopez
Modified:
6 days, 19 hours ago
Reviewers:
mathias, Fred
Visibility:
Public.

Description

#7320 - Introduce helpcenter role

Patch Set 1 #

Total comments: 38

Patch Set 2 : For comments 2 to 4 #

Total comments: 44

Patch Set 3 : For comments 5 and 6 #

Total comments: 8

Patch Set 4 : For comments 8 and 9 #

Total comments: 4

Patch Set 5 : For comments 11 and 12 #

Patch Set 6 : A bit more documentation #

Patch Set 7 : Make documentation right #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -1 line) Patch
A hiera/roles/web/static/helpcenter.yaml View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
A modules/adblockplus/manifests/web/static.pp View 1 2 3 4 5 6 1 chunk +123 lines, -0 lines 0 comments Download
A modules/adblockplus/manifests/web/static/hook.pp View 1 2 3 4 5 6 1 chunk +47 lines, -0 lines 0 comments Download
A modules/adblockplus/templates/web/hooks_wrapper.sh.erb View 1 2 3 1 chunk +31 lines, -0 lines 0 comments Download
A modules/adblockplus/templates/web/static.conf.erb View 1 2 1 chunk +80 lines, -0 lines 0 comments Download
M modules/private-stub/hiera/hosts.yaml View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 16
f.lopez
4 weeks, 1 day ago (2018-03-27 03:53:32 UTC) #1
mathias
https://codereview.adblockplus.org/29733731/diff/29733732/hiera/roles/web/static/helpcenter.yaml File hiera/roles/web/static/helpcenter.yaml (right): https://codereview.adblockplus.org/29733731/diff/29733732/hiera/roles/web/static/helpcenter.yaml#newcode6 hiera/roles/web/static/helpcenter.yaml:6: - "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAACcgC+yCp66GDc1iWCXRv/mZslxfG83uUHdOtPiOA2qtZwj6KheWbfTgB2KcV4MiXrgIT/ls8w43zZf4mhVwNXnW295v6i24qAC6qjL08M134MgcCuS+Gz+Ma30YZUwT9ZQWJRp4y9UnZbXQ+Nkl0bS2XQrVbGWP0VnIbXNtoUYb/XOm+twnccgVPsqMg9AAcVKPINrcW+2Lr77k44K8nKqbJZzb5YrQZhpj1GH3Wx/TrluzJKGVJpBz7st/gt8ulLR5ETeQAvNwAV0/h4/3+9P93euYrOzpjzDTusMOuxQ8npFyTOd4Bx56DugaLkQsbR4bu3T7kYynrVqD6MK/zxLs6Ipn3+juwybb5J5HNZKMAten+7MOA8oMF7VfIwb9Nppt8JOqSO4YoAfwCCSCvYj92JMJP8Ko0LbnAyVRmc70218jaQk+Gr7Y/TYTseEGAVa/z3emvHc7tH2osyh+IX/WnIR+tApaWd1kTS2Xifo5i91pQbwvBZRccL8YUTP97pEkNDNe0LXesyEgCtepe4qFIg2x2oHgx8Y8PmC+XwY0cJ/z6qZ6nUL4l2ccVcA5Z/o27Vaj4zmVgGSOaukkdCE7AFlTa4EIrATjlInhhYLgOBGII7zJE6HOcqufOPJnlDY5VhYeWCShSdF1d0kMl11QYOIz2CYr07SlVD/Upn7z927JKWHCfAeYb/uhJwb2eF92VluIdzLkTMO3Icv1U4Vxvif2YR2vfur3PhvDXrBuxCW8h8wLXrhOJ4Njx4MiBj3Ym4Dv+KZCaxd+Aq14HMB+EdVsFl4apm4zwakzq9dudpv1DAFgr3c8bVnNclDRxXGQEL user@Client067" Whom does that key belong ...
4 weeks ago (2018-03-27 14:46:53 UTC) #2
f.lopez
https://codereview.adblockplus.org/29733731/diff/29733732/hiera/roles/web/static/helpcenter.yaml File hiera/roles/web/static/helpcenter.yaml (right): https://codereview.adblockplus.org/29733731/diff/29733732/hiera/roles/web/static/helpcenter.yaml#newcode6 hiera/roles/web/static/helpcenter.yaml:6: - "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAACcgC+yCp66GDc1iWCXRv/mZslxfG83uUHdOtPiOA2qtZwj6KheWbfTgB2KcV4MiXrgIT/ls8w43zZf4mhVwNXnW295v6i24qAC6qjL08M134MgcCuS+Gz+Ma30YZUwT9ZQWJRp4y9UnZbXQ+Nkl0bS2XQrVbGWP0VnIbXNtoUYb/XOm+twnccgVPsqMg9AAcVKPINrcW+2Lr77k44K8nKqbJZzb5YrQZhpj1GH3Wx/TrluzJKGVJpBz7st/gt8ulLR5ETeQAvNwAV0/h4/3+9P93euYrOzpjzDTusMOuxQ8npFyTOd4Bx56DugaLkQsbR4bu3T7kYynrVqD6MK/zxLs6Ipn3+juwybb5J5HNZKMAten+7MOA8oMF7VfIwb9Nppt8JOqSO4YoAfwCCSCvYj92JMJP8Ko0LbnAyVRmc70218jaQk+Gr7Y/TYTseEGAVa/z3emvHc7tH2osyh+IX/WnIR+tApaWd1kTS2Xifo5i91pQbwvBZRccL8YUTP97pEkNDNe0LXesyEgCtepe4qFIg2x2oHgx8Y8PmC+XwY0cJ/z6qZ6nUL4l2ccVcA5Z/o27Vaj4zmVgGSOaukkdCE7AFlTa4EIrATjlInhhYLgOBGII7zJE6HOcqufOPJnlDY5VhYeWCShSdF1d0kMl11QYOIz2CYr07SlVD/Upn7z927JKWHCfAeYb/uhJwb2eF92VluIdzLkTMO3Icv1U4Vxvif2YR2vfur3PhvDXrBuxCW8h8wLXrhOJ4Njx4MiBj3Ym4Dv+KZCaxd+Aq14HMB+EdVsFl4apm4zwakzq9dudpv1DAFgr3c8bVnNclDRxXGQEL user@Client067" On 2018/03/27 14:46:50, mathias wrote: ...
4 weeks ago (2018-03-27 19:29:51 UTC) #3
f.lopez
https://codereview.adblockplus.org/29733731/diff/29733732/modules/adblockplus/templates/web/static.conf.erb File modules/adblockplus/templates/web/static.conf.erb (right): https://codereview.adblockplus.org/29733731/diff/29733732/modules/adblockplus/templates/web/static.conf.erb#newcode61 modules/adblockplus/templates/web/static.conf.erb:61: location ~ ^/([a-z][a-z]\_[A-Z][A-Z])(/.+) On 2018/03/27 14:46:52, mathias wrote: > ...
3 weeks, 6 days ago (2018-03-28 16:05:09 UTC) #4
mathias
https://codereview.adblockplus.org/29733731/diff/29740568/hiera/roles/web/static/helpcenter.yaml File hiera/roles/web/static/helpcenter.yaml (right): https://codereview.adblockplus.org/29733731/diff/29740568/hiera/roles/web/static/helpcenter.yaml#newcode5 hiera/roles/web/static/helpcenter.yaml:5: hooks: One cannot overwrite the `hooks` unless they're given ...
2 weeks, 6 days ago (2018-04-05 01:12:31 UTC) #5
f.lopez
https://codereview.adblockplus.org/29733731/diff/29740568/hiera/roles/web/static/helpcenter.yaml File hiera/roles/web/static/helpcenter.yaml (right): https://codereview.adblockplus.org/29733731/diff/29740568/hiera/roles/web/static/helpcenter.yaml#newcode5 hiera/roles/web/static/helpcenter.yaml:5: hooks: On 2018/04/05 01:12:28, mathias wrote: > One cannot ...
2 weeks, 1 day ago (2018-04-10 02:45:40 UTC) #6
f.lopez
2 weeks, 1 day ago (2018-04-10 02:45:59 UTC) #7
mathias
https://codereview.adblockplus.org/29733731/diff/29747666/modules/adblockplus/manifests/web/static.pp File modules/adblockplus/manifests/web/static.pp (right): https://codereview.adblockplus.org/29733731/diff/29747666/modules/adblockplus/manifests/web/static.pp#newcode21 modules/adblockplus/manifests/web/static.pp:21: # Whether to set up the website or not. ...
1 week ago (2018-04-17 15:57:14 UTC) #8
f.lopez
https://codereview.adblockplus.org/29733731/diff/29747666/modules/adblockplus/manifests/web/static.pp File modules/adblockplus/manifests/web/static.pp (right): https://codereview.adblockplus.org/29733731/diff/29747666/modules/adblockplus/manifests/web/static.pp#newcode21 modules/adblockplus/manifests/web/static.pp:21: # Whether to set up the website or not. ...
1 week ago (2018-04-17 18:02:23 UTC) #9
f.lopez
1 week ago (2018-04-17 18:02:48 UTC) #10
mathias
https://codereview.adblockplus.org/29733731/diff/29754571/hiera/roles/web/static/helpcenter.yaml File hiera/roles/web/static/helpcenter.yaml (right): https://codereview.adblockplus.org/29733731/diff/29754571/hiera/roles/web/static/helpcenter.yaml#newcode9 hiera/roles/web/static/helpcenter.yaml:9: content: "uname -a" Couldn't that one use `target: /bin/uname` ...
1 week ago (2018-04-17 19:28:05 UTC) #11
f.lopez
https://codereview.adblockplus.org/29733731/diff/29754571/hiera/roles/web/static/helpcenter.yaml File hiera/roles/web/static/helpcenter.yaml (right): https://codereview.adblockplus.org/29733731/diff/29754571/hiera/roles/web/static/helpcenter.yaml#newcode9 hiera/roles/web/static/helpcenter.yaml:9: content: "uname -a" On 2018/04/17 19:28:04, mathias wrote: > ...
1 week ago (2018-04-17 19:52:49 UTC) #12
f.lopez
1 week ago (2018-04-17 19:53:08 UTC) #13
f.lopez
1 week ago (2018-04-17 19:59:00 UTC) #14
f.lopez
1 week ago (2018-04-17 20:03:37 UTC) #15
mathias
1 week ago (2018-04-17 20:04:42 UTC) #16
lgtm.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5