#7320 - Introduce helpcenter role

modules/adblockplus/manifests/web/static/hook.pp

+# == Type: adblockplus::web::static::hook
+#
+# Manage custom hooks to be triggered via ssh commands
+#
+# === Parameters:
+#
+# [*file*]
+#   Overwrite the default configuration for the hook.

[mathias, 2018/04/05 01:12:30]

This is not a default but totally necessary, in the current version that is.

[f.lopez, 2018/04/10 02:45:39]

Acknowledged.

+#
+# === Examples:
+#
+#  adblockplus::web::static::hook {'deploy':
+#    'file' => {
+#      source => 'puppet:///modules/adblockplus/web/deploy.py',
+#      path => '/usr/local/bin/deploy.py',
+#    },
+#   }
+#
+#  adblockplus::web::static::hook {'uname':
+#    'file' => {
+#      content => 'uname -a',
+#    },
+#  }
+#
+define adblockplus::web::static::hook (
+  $file = {},
+) {
+
+  ensure_resource('file', "hook#${name}", merge({

[mathias, 2018/04/05 01:12:30]

When composing titles, which are required to be unique per resource type, you
should use $title for that exact reason. Not $name, which only defaults to
$title but is not restricted in the same fashion.

Also the prefix "hook" is not really distinct enough: It is totally possible to
have a "hook#test" in this setup and some auxiliary system, i.e. monitoring or
something, on the same node. A "web-deploy-hook#test" and
"monitor-alert-hook#test" would be way better, right?

[f.lopez, 2018/04/10 02:45:39]

Acknowledged.

+    mode => '0755',
+    owner =>$adblockplus::web::static::deploy_user,

[mathias, 2018/04/05 01:12:30]

There's a space missing here.

[f.lopez, 2018/04/10 02:45:39]

Acknowledged.

+    group => $adblockplus::web::static::deploy_user,
+  }, $file, {
+    ensure => ensure_file_state($adblockplus::web::static::ensure),
+    path => "/home/$adblockplus::web::static::deploy_user/bin/${name}",

[mathias, 2018/04/05 01:12:30]

Both variables should be denoted with the `${}` syntax.

[f.lopez, 2018/04/10 02:45:39]

Acknowledged.

+  }))
+}
+