Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(362)

Issue 29734562: Issue 6526 - update usage of V8 API (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 8 months ago by sergei
Modified:
1 year, 8 months ago
Reviewers:
hub, René Jeschke
CC:
anton
Base URL:
https://github.com/adblockplus/libadblockplus@18cc8b26874862bdc75c1cce28bd7b490066c659
Visibility:
Public.

Description

It addresses only few places which were identified while trying to update to V8 6.5.254.41 during the work on #6063.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/FileSystemJsObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/JsEngine.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/JsValue.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
sergei
1 year, 8 months ago (2018-03-27 11:40:23 UTC) #1
hub
1 year, 8 months ago (2018-03-27 13:51:48 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5