Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(361)

Issue 29735555: Issue 6526 - replace deprecated v8::Handle by v8::Local (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 8 months ago by sergei
Modified:
1 year, 8 months ago
Reviewers:
hub, René Jeschke
Base URL:
https://github.com/adblockplus/libadblockplus@ef3f884a2efa47ace996398da09afe3d0ce647f0
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -22 lines) Patch
src/JsEngine.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
src/JsError.h View 1 chunk +4 lines, -4 lines 0 comments Download
src/JsError.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
src/JsValue.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
src/Utils.h View 1 chunk +2 lines, -2 lines 0 comments Download
src/Utils.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
sergei
1 year, 8 months ago (2018-03-28 08:31:02 UTC) #1
hub
the diff view is broken :-(
1 year, 8 months ago (2018-03-28 22:23:42 UTC) #2
hub
1 year, 8 months ago (2018-03-28 22:25:05 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5