Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/JsEngine.cpp

Issue 29735555: Issue 6526 - replace deprecated v8::Handle by v8::Local (Closed) Base URL: https://github.com/adblockplus/libadblockplus@ef3f884a2efa47ace996398da09afe3d0ce647f0
Patch Set: Created March 28, 2018, 8:06 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/JsError.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/JsEngine.cpp
diff --git a/src/JsEngine.cpp b/src/JsEngine.cpp
index a2bcf9a423d94a86955c97cf4597d243e1e1306a..621df56ec8d33aaeb7353fe2ca58bc6014c3f79a 100644
--- a/src/JsEngine.cpp
+++ b/src/JsEngine.cpp
@@ -25,14 +25,14 @@
namespace
{
- v8::Handle<v8::Script> CompileScript(v8::Isolate* isolate,
+ v8::Local<v8::Script> CompileScript(v8::Isolate* isolate,
const std::string& source, const std::string& filename)
{
using AdblockPlus::Utils::ToV8String;
- const v8::Handle<v8::String> v8Source = ToV8String(isolate, source);
+ const v8::Local<v8::String> v8Source = ToV8String(isolate, source);
if (filename.length())
{
- const v8::Handle<v8::String> v8Filename = ToV8String(isolate, filename);
+ const v8::Local<v8::String> v8Filename = ToV8String(isolate, filename);
return v8::Script::Compile(v8Source, v8Filename);
}
else
@@ -191,7 +191,7 @@ AdblockPlus::JsValue AdblockPlus::JsEngine::Evaluate(const std::string& source,
{
const JsContext context(*this);
const v8::TryCatch tryCatch(GetIsolate());
- const v8::Handle<v8::Script> script = CompileScript(GetIsolate(), source,
+ const v8::Local<v8::Script> script = CompileScript(GetIsolate(), source,
filename);
CheckTryCatch(tryCatch);
v8::Local<v8::Value> result = script->Run();
« no previous file with comments | « no previous file | src/JsError.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld