Issue 6501 - Remove CI references from KittCore

KittCore.xcodeproj/project.pbxproj

 // !$*UTF8*$!
 {
         archiveVersion = 1;
         classes = {
         };
         objectVersion = 46;
         objects = {
 
 /* Begin PBXBuildFile section */
                 69006ECE1CEB132E00ECF05E /* ProviderFindInPage.swift in Sources */ = {isa = PBXBuildFile; fileRef = 69006ECD1CEB132E00ECF05E /* ProviderFindInPage.swift */; };
@@ skipping 1579 matching lines @@
                         buildActionMask = 2147483647;
                         files = (
                         );
                         inputPaths = (
                         );
                         name = "Patch Info.plist";
                         outputPaths = (
                         );
                         runOnlyForDeploymentPostprocessing = 0;
                         shellPath = /bin/sh;
-                        shellScript = "./deploy/patch-appinfo.sh .. package.json $CORE_BUILD_NUMBER";
+                        shellScript = "./deploy/patch-appinfo.sh .. package.json";
                 };
                 E95A61211C4D3E1500433F91 /* Patch Info.plist */ = {
                         isa = PBXShellScriptBuildPhase;
                         buildActionMask = 2147483647;
                         files = (
                         );
                         inputPaths = (
                         );
                         name = "Patch Info.plist";
                         outputPaths = (
                         );
                         runOnlyForDeploymentPostprocessing = 0;
                         shellPath = /bin/sh;
-                        shellScript = "./deploy/patch-appinfo.sh .. package.json $CORE_BUILD_NUMBER";
+                        shellScript = "./deploy/patch-appinfo.sh .. package.json";
                 };
                 E9EC73191B25DB1600C4C905 /* Npm + Grunt build JS API */ = {
                         isa = PBXShellScriptBuildPhase;
                         buildActionMask = 12;
                         files = (
                         );
                         inputPaths = (
                         );
                         name = "Npm + Grunt build JS API";
                         outputPaths = (
                         );
                         runOnlyForDeploymentPostprocessing = 0;
                         shellPath = /bin/sh;
-                        shellScript = "./deploy/build-jsapi.sh .. xcode $CORE_BUILD_NUMBER";

[d108, 2018/03/29 02:20:38]

The build number doesn't seem to go here.

See build-jsapi.sh:

HAS_CI=$3 # unset or the specific CI env var saying "it's running in CI"

+                        shellScript = "./deploy/build-jsapi.sh .. xcode";
                         showEnvVarsInLog = 0;
                 };
 /* End PBXShellScriptBuildPhase section */
 
 /* Begin PBXSourcesBuildPhase section */
                 E9EC6FFD1B25D79800C4C905 /* Sources */ = {
                         isa = PBXSourcesBuildPhase;
                         buildActionMask = 2147483647;
                         files = (
                                 69FC932A1B5CF4A600CBFFA3 /* ProviderDuckDuckGo.swift in Sources */,
@@ skipping 690 matching lines @@
                         );
                         currentVersion = E9C062881B3C07410041F6D9 /* Extensions.xcdatamodel */;
                         path = Extensions.xcdatamodeld;
                         sourceTree = "<group>";
                         versionGroupType = wrapper.xcdatamodel;
                 };
 /* End XCVersionGroup section */
         };
         rootObject = E9EC6FF91B25D79800C4C905 /* Project object */;
 }