Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: desktop-options.html

Issue 29736629: Issue 6532 - Removes required subscription title input field (Closed) Base URL: https://hg.adblockplus.org/adblockplusui
Patch Set: Created March 30, 2018, 3:30 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | locale/ar/desktop-options.json » ('j') | locale/en_US/desktop-options.json » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 - This file is part of Adblock Plus <https://adblockplus.org/>, 3 - This file is part of Adblock Plus <https://adblockplus.org/>,
4 - Copyright (C) 2006-present eyeo GmbH 4 - Copyright (C) 2006-present eyeo GmbH
5 - 5 -
6 - Adblock Plus is free software: you can redistribute it and/or modify 6 - Adblock Plus is free software: you can redistribute it and/or modify
7 - it under the terms of the GNU General Public License version 3 as 7 - it under the terms of the GNU General Public License version 3 as
8 - published by the Free Software Foundation. 8 - published by the Free Software Foundation.
9 - 9 -
10 - Adblock Plus is distributed in the hope that it will be useful, 10 - Adblock Plus is distributed in the hope that it will be useful,
(...skipping 381 matching lines...) Expand 10 before | Expand all | Expand 10 after
392 </span> 392 </span>
393 </span> 393 </span>
394 </button> 394 </button>
395 </template> 395 </template>
396 </ul> 396 </ul>
397 </div> 397 </div>
398 <!-- Add import subscription --> 398 <!-- Add import subscription -->
399 <div id="dialog-content-import" class="dialog-content"> 399 <div id="dialog-content-import" class="dialog-content">
400 <form data-validation="custom" novalidate> 400 <form data-validation="custom" novalidate>
401 <p class="floating-input"> 401 <p class="floating-input">
402 <input placeholder=" " id="import-list-title" type="text" class="d efault-focus" required />
Thomas Greiner 2018/04/03 14:11:04 You're removing an element with the class "default
Thomas Greiner 2018/04/03 14:11:04 We're still trying to access its value in js/deskt
Jon Sonesen 2018/04/06 01:10:09 Acknowledged.
403 <label for="import-list-title" class="i18n_options_dialog_import_s ubscription_title"></label>
404 <span class="icon attention"></span>
405 <span class="i18n_options_dialog_import_subscription_title_error e rror-msg"></span>
406 </p>
407 <p class="floating-input">
Jon Sonesen 2018/03/30 03:37:19 One thing I was thinking, is that maybe this doesn
Thomas Greiner 2018/04/03 14:11:04 "Floating input" doesn't refer to CSS's "float" pr
Jon Sonesen 2018/04/06 01:10:09 Acknowledged.
408 <input placeholder=" " id="import-list-url" type="url" required/> 402 <input placeholder=" " id="import-list-url" type="url" required/>
409 <label for="import-list-url" class="i18n_options_dialog_import_sub scription_location"></label> 403 <label for="import-list-url" class="i18n_options_dialog_import_sub scription_location"></label>
410 <span class="icon attention"></span> 404 <span class="icon attention"></span>
411 <span class="i18n_options_dialog_import_subscription_location_erro r error-msg"></span> 405 <span class="i18n_options_dialog_import_subscription_location_erro r error-msg"></span>
412 </p> 406 </p>
413 <p class="side-controls"> 407 <p class="side-controls">
414 <button class="i18n_options_customFilter_cancel secondary" type="r eset" data-action="close-dialog"></button> 408 <button class="i18n_options_customFilter_cancel secondary" type="r eset" data-action="close-dialog"></button>
415 <button type="button" class="i18n_options_dialog_import_title prim ary" data-action="validate-import-subscription"></button> 409 <button type="button" class="i18n_options_dialog_import_title prim ary" data-action="validate-import-subscription"></button>
416 </p> 410 </p>
417 </form> 411 </form>
(...skipping 12 matching lines...) Expand all
430 </div> 424 </div>
431 <!-- Notification --> 425 <!-- Notification -->
432 <div id="notification" aria-hidden="true" aria-live="polite"> 426 <div id="notification" aria-hidden="true" aria-live="polite">
433 <strong id="notification-text"></strong> 427 <strong id="notification-text"></strong>
434 <button class="icon close secondary" data-action="hide-notification"> 428 <button class="icon close secondary" data-action="hide-notification">
435 <span class="i18n_options_notification_hide sr-only"></span> 429 <span class="i18n_options_notification_hide sr-only"></span>
436 </button> 430 </button>
437 </div> 431 </div>
438 </body> 432 </body>
439 </html> 433 </html>
OLDNEW
« no previous file with comments | « no previous file | locale/ar/desktop-options.json » ('j') | locale/en_US/desktop-options.json » ('J')

Powered by Google App Engine
This is Rietveld