Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: js/desktop-options.js

Issue 29736629: Issue 6532 - Removes required subscription title input field (Closed) Base URL: https://hg.adblockplus.org/adblockplusui
Left Patch Set: Created March 30, 2018, 3:30 a.m.
Right Patch Set: Address PS2 comments Created April 9, 2018, 8:46 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Right: Side by side diff | Download
« no previous file with change/comment | « desktop-options.html ('k') | locale/en_US/desktop-options.json » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
(no file at all)
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 719 matching lines...) Expand 10 before | Expand all | Expand 10 after
730 url: findParentData(element, "access", false) 730 url: findParentData(element, "access", false)
731 }); 731 });
732 break; 732 break;
733 case "validate-import-subscription": 733 case "validate-import-subscription":
734 let form = findParentData(element, "validation", true); 734 let form = findParentData(element, "validation", true);
735 if (!form) 735 if (!form)
736 return; 736 return;
737 737
738 if (form.checkValidity()) 738 if (form.checkValidity())
739 { 739 {
740 addEnableSubscription(E("import-list-url").value, 740 addEnableSubscription(E("import-list-url").value);
741 E("import-list-title").value);
742 form.reset(); 741 form.reset();
743 closeDialog(); 742 closeDialog();
744 } 743 }
745 else 744 else
746 { 745 {
747 form.querySelector(":invalid").focus(); 746 form.querySelector(":invalid").focus();
748 } 747 }
749 break; 748 break;
750 } 749 }
751 } 750 }
(...skipping 748 matching lines...) Expand 10 before | Expand all | Expand 10 after
1500 "ui_warn_tracking"] 1499 "ui_warn_tracking"]
1501 }); 1500 });
1502 port.postMessage({ 1501 port.postMessage({
1503 type: "subscriptions.listen", 1502 type: "subscriptions.listen",
1504 filter: ["added", "disabled", "homepage", "lastDownload", "removed", 1503 filter: ["added", "disabled", "homepage", "lastDownload", "removed",
1505 "title", "downloadStatus", "downloading"] 1504 "title", "downloadStatus", "downloading"]
1506 }); 1505 });
1507 1506
1508 window.addEventListener("DOMContentLoaded", onDOMLoaded, false); 1507 window.addEventListener("DOMContentLoaded", onDOMLoaded, false);
1509 window.addEventListener("hashchange", onHashChange, false); 1508 window.addEventListener("hashchange", onHashChange, false);
LEFTRIGHT

Powered by Google App Engine
This is Rietveld