Issue 6538, 6781 - Implement support for snippet filters

lib/filterClasses.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 1011 matching lines @@
   body: null
 });
 
 /**
  * Creates a content filter from a pre-parsed text representation
  *
  * @param {string} text         same as in Filter()
  * @param {string} [domains]
  *   domains part of the text representation
  * @param {string} [type]
- *   rule type, either empty or @ (exception) or ? (emulation rule) or
- *   $ (snippet)
+ *   rule type, either:
+ *     <li>"" for an element hiding filter</li>

[Manish Jethani, 2018/07/11 13:04:26]

Using just "-" doesn't work in the HTML version, but we can use <li> instead.

We should really switch to Markdown in the comments.

[kzar, 2018/07/11 17:17:52]

Acknowledged.

+ *     <li>"@" for an element hiding exception filter</li>
+ *     <li>"?" for an element hiding emulation filter</li>
+ *     <li>"$" for a snippet filter</li>
  * @param {string} body
  *   body part of the text representation, either a CSS selector or a snippet
  *   script
  * @return {ElemHideFilter|ElemHideException|
  *          ElemHideEmulationFilter|SnippetFilter|InvalidFilter}
  */
 ContentFilter.fromText = function(text, domains, type, body)
 {
   // We don't allow content filters which have any empty domains.
   // Note: The ContentFilter.prototype.domainSeparator is duplicated here, if
@@ skipping 115 matching lines @@
 }
 exports.SnippetFilter = SnippetFilter;
 
 SnippetFilter.prototype = extend(ContentFilter, {
   type: "snippet",
 
   /**
    * Script that should be executed
    * @type {string}
    */
   get script()

[Manish Jethani, 2018/07/11 13:04:25]

I would prefer to stick to this terminology for Snippets:

  snippet - some executable function (JS or WebAssembly, doesn't matter what it
is) that takes parameters

  snippet script - code that invokes one or more snippets with zero or more
arguments each

  snippet filter - a list of domains plus a snippet script

[kzar, 2018/07/11 17:17:52]

Yes, I agree, "script" makes sense for snippet filters.

   {
     return this.body;
   }
 });