Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29738571: Issue 6542 - Fix colors of the devtools resource URLs (Closed)

Created:
March 31, 2018, 11:05 a.m. by kzar
Modified:
April 4, 2018, 11:04 a.m.
Reviewers:
Thomas Greiner
CC:
Sebastian Noack, a.giammarchi, saroyanm
Visibility:
Public.

Description

Issue 6542 - Fix colors of the devtools resource URLs

Patch Set 1 #

Total comments: 2

Patch Set 2 : Separate selectors with newlines #

Patch Set 3 : Have link elements inherit colour from parent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M skin/devtools-panel.css View 1 2 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 8
kzar
Patch Set 1
March 31, 2018, 11:06 a.m. (2018-03-31 11:06:42 UTC) #1
Thomas Greiner
https://codereview.adblockplus.org/29738571/diff/29738572/skin/devtools-panel.css File skin/devtools-panel.css (right): https://codereview.adblockplus.org/29738571/diff/29738572/skin/devtools-panel.css#newcode39 skin/devtools-panel.css:39: body, a Coding style: "Separate selectors and declarations by ...
April 3, 2018, 12:20 p.m. (2018-04-03 12:20:29 UTC) #2
kzar
Patch Set 2 : Separate selectors with newlines https://codereview.adblockplus.org/29738571/diff/29738572/skin/devtools-panel.css File skin/devtools-panel.css (right): https://codereview.adblockplus.org/29738571/diff/29738572/skin/devtools-panel.css#newcode39 skin/devtools-panel.css:39: body, ...
April 3, 2018, 3:15 p.m. (2018-04-03 15:15:40 UTC) #3
Thomas Greiner
Sorry for bringing this up just now but what about using `a {color: inherit}` so ...
April 3, 2018, 3:53 p.m. (2018-04-03 15:53:10 UTC) #4
kzar
Patch Set 3 : Have link elements inherit colour from parent > Sorry for bringing ...
April 3, 2018, 4:18 p.m. (2018-04-03 16:18:23 UTC) #5
Thomas Greiner
Thanks, LGTM
April 3, 2018, 5:32 p.m. (2018-04-03 17:32:51 UTC) #6
kzar
On 2018/04/03 17:32:51, Thomas Greiner wrote: > Thanks, LGTM Since this is a regression since ...
April 3, 2018, 6:38 p.m. (2018-04-03 18:38:55 UTC) #7
Thomas Greiner
April 4, 2018, 10:07 a.m. (2018-04-04 10:07:14 UTC) #8
On 2018/04/03 18:38:55, kzar wrote:
> Since this is a regression since the last Chrome release I'd like to push this
> now, any objections?

No objections from me.

Powered by Google App Engine
This is Rietveld