Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/popupBlocker.js

Issue 29739594: Issue 6543 - Match requests without tabId/frameId in their originating context (Closed)
Patch Set: Use URL patterns to find tabs for initiator Created April 4, 2018, 1:01 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/popupBlocker.js
===================================================================
--- a/lib/popupBlocker.js
+++ b/lib/popupBlocker.js
@@ -48,7 +48,7 @@
let thirdParty = isThirdParty(urlObj, documentHost);
let specificOnly = !!checkWhitelisted(
- popup.sourcePage, popup.sourceFrame,
+ popup.sourcePage, popup.sourceFrame, null,
RegExpFilter.typeMap.GENERICBLOCK
);
« no previous file with comments | « lib/filterComposer.js ('k') | lib/requestBlocker.js » ('j') | lib/requestBlocker.js » ('J')

Powered by Google App Engine
This is Rietveld