Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: devtools-panel.html

Issue 29740563: Noissue - In the devtools panel, preserve space for missing document domain (Closed)
Patch Set: Created April 2, 2018, 6:47 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « background.js ('k') | devtools-panel.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 - This file is part of Adblock Plus <https://adblockplus.org/>, 3 - This file is part of Adblock Plus <https://adblockplus.org/>,
4 - Copyright (C) 2006-present eyeo GmbH 4 - Copyright (C) 2006-present eyeo GmbH
5 - 5 -
6 - Adblock Plus is free software: you can redistribute it and/or modify 6 - Adblock Plus is free software: you can redistribute it and/or modify
7 - it under the terms of the GNU General Public License version 3 as 7 - it under the terms of the GNU General Public License version 3 as
8 - published by the Free Software Foundation. 8 - published by the Free Software Foundation.
9 - 9 -
10 - Adblock Plus is distributed in the hope that it will be useful, 10 - Adblock Plus is distributed in the hope that it will be useful,
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 </div> 81 </div>
82 <footer> 82 <footer>
83 <a id="reload">Reload</a> page to see effect of filter changes 83 <a id="reload">Reload</a> page to see effect of filter changes
84 </footer> 84 </footer>
85 85
86 <template> 86 <template>
87 <tr> 87 <tr>
88 <td> 88 <td>
89 <div class="request-wrapper"> 89 <div class="request-wrapper">
90 <a class="resource-link" href="" target="_blank">&nbsp;</a> 90 <a class="resource-link" href="" target="_blank">&nbsp;</a>
91 <div class="domain"></div> 91 <div class="domain">&nbsp;</div>
Thomas Greiner 2018/04/03 12:39:43 This issue is purely cosmetical so, instead of not
Sebastian Noack 2018/04/03 23:21:56 Well, this is how we already avoid other elements
Thomas Greiner 2018/04/04 12:34:01 Sure, we should avoid any major refactoring. So if
Sebastian Noack 2018/04/05 00:36:10 It's a hack to superfluously define a height on th
92 </div> 92 </div>
93 </td> 93 </td>
94 <td> 94 <td>
95 <div class="type"></div> 95 <div class="type"></div>
96 </td> 96 </td>
97 <td> 97 <td>
98 <div class="action-wrapper"> 98 <div class="action-wrapper">
99 <div class="filter-wrapper"> 99 <div class="filter-wrapper">
100 <div class="filter">&nbsp;</div> 100 <div class="filter">&nbsp;</div>
101 <div class="origin">&nbsp;</div> 101 <div class="origin">&nbsp;</div>
102 </div> 102 </div>
103 </div> 103 </div>
104 </td> 104 </td>
105 </tr> 105 </tr>
106 </template> 106 </template>
107 </body> 107 </body>
108 </html> 108 </html>
OLDNEW
« no previous file with comments | « background.js ('k') | devtools-panel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld