Issue 6552 - Support arbitrary manifest values

templates/manifest.json.tmpl

 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 {
   "manifest_version": 2,
   {%- if releaseBuild %}
   "name": "__MSG_name__",
   {%- else %}
   "name": "__MSG_name_devbuild__",
@@ skipping 52 matching lines @@
   "browser_action": {
     "default_icon": {{browserAction.icon|json}},
     {%- if browserAction.popup %}
     "default_popup": {{browserAction.popup|json}},
     {%- endif %}
     "default_title": "__MSG_name__"
   },
   {%- endif %}
 
   {%- if icons %}
   "icons": {{icons|json}},

[Sebastian Noack, 2018/04/14 00:33:07]

I guess content_security_policy can also be handled generically now?

[tlucas, 2018/04/14 08:36:24]

Yes - same applies to e.g. "managedStorageSchema".
I will compare the buildtools' metadata.* with the adblockpluschrome's
metadata.*, to find other keys which can be added generically now.

(just wondering, did you put this note under "icons" on purpose?)

[Sebastian Noack, 2018/04/14 08:54:26]

Yeah, storage.managed_scheme as well. I think that's it. As far as I can tell
all the other keys involve some processing.
When looking at the unified diff, content_Security_policy wasn't in the context
and this was the top most line I could comment on. I just noticed when looking
at side-by-side diffs, I can expand the whole file.

   {%- endif %}
 
-  {%- if permissions %}
-  "permissions": {{permissions|json}},
-  {%- endif %}
-
-  {%- if optionalPermissions %}
-    "optional_permissions": {{optionalPermissions|json}},
+  {%- if extra %}
+    {%- for k, v in extra.items() %}
+  "{{k}}":{{v|json}},
+    {%- endfor %}
   {%- endif %}
 
   {%- if backgroundScripts %}
   "background": {
     "scripts": {{backgroundScripts|json}},
     "persistent": true
   },
   {%- endif %}
 
   {%- if metadata.has_option('general', 'options') %}
   {%- if type != 'edge' %}
   "options_ui": {
     "page": {{metadata.get('general', 'options')|json}},
     "open_in_tab": true
   },
   {%- else %}
   "options_page": {{metadata.get('general', 'options')|json}},
   {%- endif %}
   {%- endif %}
 
   {%- if metadata.has_option('general', 'devtools') %}
   "devtools_page": {{metadata.get('general', 'devtools')|json}},
   {%- endif %}
 
   {%- if contentScripts %}
   "content_scripts": {{contentScripts|json}},
   {%- endif %}
 
-  {%- if webAccessible %}
-  "web_accessible_resources": {{webAccessible|json}},
-  {%- endif %}
-
   {%- if metadata.has_option('general', 'managedStorageSchema') %}
   "storage": {
     "managed_schema": {{metadata.get('general', 'managedStorageSchema')|json}}
   },
   {%- endif %}
 
   {%- if metadata.has_option('general', 'contentSecurityPolicy') %}
   "content_security_policy": {{metadata.get('general', 'contentSecurityPolicy')|json}},
   {%- endif %}
 
   "_dummy": false
 }