tests/metadata.chrome - Issue 29743581: Issue 6552 - Support arbitrary manifest values

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: tests/metadata.chrome

Issue 29743581: Issue 6552 - Support arbitrary manifest values (Closed) Base URL: https://hg.adblockplus.org/buildtools/file/a3db4a1a49e8

Patch Set: Issue 6552 - Support arbitrary manifest values Created April 11, 2018, 9:42 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: tests/metadata.chrome

diff --git a/tests/metadata.chrome b/tests/metadata.chrome

index fd5c342937561289ce9b0bfac59a98e74649f98b..7a4d747e7633bc48a3d8e755977d39bf4ee73068 100644

--- a/tests/metadata.chrome

+++ b/tests/metadata.chrome

@@ -2,9 +2,6 @@

version = 1.2.3

author = eyeo GmbH

basename = adblockpluschrome

-permissions = tabs

- <all_urls>

-optionalPermissions = webRequest

backgroundScripts = ext/common.js

ext/background.js

testScripts = ../ext/common.js

@@ -14,7 +11,17 @@ options = options.html

managedStorageSchema = storage.json

browserAction = icons/abp-16.png icons/abp-19.png icons/abp-53.png popup.html

icons = icons/abp-16.png

-webAccessible = images/*.png

Sebastian Noack 2018/04/12 12:19:24 Please update https://issues.adblockplus.org/ticke

tlucas 2018/04/12 13:47:39 Will do, as soon as we sorted out, what actually n

+[manifest]

+permissions[] = tabs

Sebastian Noack 2018/04/12 12:19:23 I think its more readable if we put all items on a

tlucas 2018/04/12 13:47:39 Done.

+ <all_urls>

+optionalPermissions[] = webRequest

+webAccessible[] = images/*.png

+externallyConnectable.matches[] = https://*.google.com/*

+ *://*.chromium.org/*

+externallyConnectable.ids[] = foo

+ bar

+externallyConnectable.accepts_tls_channel_id = true\b

[contentScripts]

planets = content.js