Issue 6552 - Support arbitrary manifest values

templates/manifest.json.tmpl

Index: templates/manifest.json.tmpl
diff --git a/templates/manifest.json.tmpl b/templates/manifest.json.tmpl
index e2cf347d08c8b8bdcbff4b73b24f3c2eed281e79..db2186ea1a8481af189a50fe0dd36c5a1dc5c317 100644
--- a/templates/manifest.json.tmpl
+++ b/templates/manifest.json.tmpl
@@ -73,12 +73,10 @@
   "icons": {{icons|json}},

[Sebastian Noack, 2018/04/14 00:33:07]

I guess content_security_policy can also be handled generically now?

[tlucas, 2018/04/14 08:36:24]

Yes - same applies to e.g. "managedStorageSchema".
I will compare the buildtools' metadata.* with the adblockpluschrome's
metadata.*, to find other keys which can be added generically now.

(just wondering, did you put this note under "icons" on purpose?)

[Sebastian Noack, 2018/04/14 08:54:26]

Yeah, storage.managed_scheme as well. I think that's it. As far as I can tell
all the other keys involve some processing.
When looking at the unified diff, content_Security_policy wasn't in the context
and this was the top most line I could comment on. I just noticed when looking
at side-by-side diffs, I can expand the whole file.

   {%- endif %}
 
-  {%- if permissions %}
-  "permissions": {{permissions|json}},
-  {%- endif %}
-
-  {%- if optionalPermissions %}
-    "optional_permissions": {{optionalPermissions|json}},
+  {%- if extra %}
+    {%- for k, v in extra.items() %}
+  "{{k}}":{{v|json}},
+    {%- endfor %}
   {%- endif %}
 
   {%- if backgroundScripts %}
@@ -107,10 +105,6 @@
   "content_scripts": {{contentScripts|json}},
   {%- endif %}
 
-  {%- if webAccessible %}
-  "web_accessible_resources": {{webAccessible|json}},
-  {%- endif %}
-
   {%- if metadata.has_option('general', 'managedStorageSchema') %}
   "storage": {
     "managed_schema": {{metadata.get('general', 'managedStorageSchema')|json}}