Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: packagerChrome.py

Issue 29743581: Issue 6552 - Support arbitrary manifest values (Closed) Base URL: https://hg.adblockplus.org/buildtools/file/a3db4a1a49e8
Patch Set: NOCHANGE rebase against current master (30b4e987f025) Created April 18, 2018, 2:35 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chainedconfigparser.py ('k') | templates/manifest.json.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packagerChrome.py
diff --git a/packagerChrome.py b/packagerChrome.py
index 1dadca95ccedcf55cd0ed0699fc59c11be7654f2..c675dcbcd5a3b78f7574405ef9671fdb45c055e3 100644
--- a/packagerChrome.py
+++ b/packagerChrome.py
@@ -101,27 +101,19 @@ def createManifest(params, files):
templateData[opt] = {'icon': icon, 'popup': popup}
+ # Generate templatedataa which does not need special processing
+ templateData.update({'extra': metadata.as_json_object('manifest')})
+
if metadata.has_option('general', 'icons'):
templateData['icons'] = makeIcons(files,
metadata.get('general', 'icons').split())
- if metadata.has_option('general', 'permissions'):
- templateData['permissions'] = metadata.get('general', 'permissions').split()
-
- if metadata.has_option('general', 'optionalPermissions'):
- templateData['optionalPermissions'] = metadata.get(
- 'general', 'optionalPermissions').split()
-
if metadata.has_option('general', 'backgroundScripts'):
templateData['backgroundScripts'] = metadata.get(
'general', 'backgroundScripts').split()
if params['devenv']:
templateData['backgroundScripts'].append('devenvPoller__.js')
- if metadata.has_option('general', 'webAccessible') and metadata.get('general', 'webAccessible') != '':
- templateData['webAccessible'] = metadata.get('general',
- 'webAccessible').split()
-
if metadata.has_section('contentScripts'):
contentScripts = []
for run_at, scripts in metadata.items('contentScripts'):
« no previous file with comments | « chainedconfigparser.py ('k') | templates/manifest.json.tmpl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld