Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: packagerChrome.py

Issue 29743581: Issue 6552 - Support arbitrary manifest values (Closed) Base URL: https://hg.adblockplus.org/buildtools/file/a3db4a1a49e8
Patch Set: Created April 18, 2018, 2:41 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: packagerChrome.py
diff --git a/packagerChrome.py b/packagerChrome.py
index 1dadca95ccedcf55cd0ed0699fc59c11be7654f2..7b6ea5631adc7bb52f06fbd65708d25c10998c70 100644
--- a/packagerChrome.py
+++ b/packagerChrome.py
@@ -105,23 +105,12 @@ def createManifest(params, files):
templateData['icons'] = makeIcons(files,
metadata.get('general', 'icons').split())
- if metadata.has_option('general', 'permissions'):
- templateData['permissions'] = metadata.get('general', 'permissions').split()
-
- if metadata.has_option('general', 'optionalPermissions'):
- templateData['optionalPermissions'] = metadata.get(
- 'general', 'optionalPermissions').split()
-
if metadata.has_option('general', 'backgroundScripts'):
templateData['backgroundScripts'] = metadata.get(
'general', 'backgroundScripts').split()
if params['devenv']:
templateData['backgroundScripts'].append('devenvPoller__.js')
- if metadata.has_option('general', 'webAccessible') and metadata.get('general', 'webAccessible') != '':
- templateData['webAccessible'] = metadata.get('general',
- 'webAccessible').split()
-
if metadata.has_section('contentScripts'):
contentScripts = []
for run_at, scripts in metadata.items('contentScripts'):
@@ -145,7 +134,8 @@ def createManifest(params, files):
data = json.loads(re.sub(licenseComment, '', manifest, 1))
if '_dummy' in data:
del data['_dummy']
- manifest = json.dumps(data, sort_keys=True, indent=2)
+ manifest = json.dumps(metadata.section_as_dict('manifest', data),
+ sort_keys=True, indent=2)
return manifest.encode('utf-8')

Powered by Google App Engine
This is Rietveld