ExtensionShare/Info.plist - Issue 29743618: Issue 6608 - Removed CI refs from Target settings for ABB and Share Extension

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: ExtensionShare/Info.plist

Issue 29743618: Issue 6608 - Removed CI refs from Target settings for ABB and Share Extension (Closed)

Left Patch Set: Noissue - Removed CI refs from Target settings for ABB and Share ext Created April 6, 2018, 9:56 a.m.

Right Patch Set: Issue 6608 - Remove CI refs from ABB. Added BUILD_NUMBER and made issue number also. Created April 23, 2018, 8:35 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 <?xml version="1.0" encoding="UTF-8"?>	1 <?xml version="1.0" encoding="UTF-8"?>

2 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/ PropertyList-1.0.dtd">	2 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/ PropertyList-1.0.dtd">

3 <plist version="1.0">	3 <plist version="1.0">

4 <dict>	4 <dict>

5 <key>CFBundleDevelopmentRegion</key>	5 <key>CFBundleDevelopmentRegion</key>

6 <string>en</string>	6 <string>en</string>

7 <key>CFBundleDisplayName</key>	7 <key>CFBundleDisplayName</key>

8 <string>Adblock Browser</string>	8 <string>Adblock Browser</string>

9 <key>CFBundleExecutable</key>	9 <key>CFBundleExecutable</key>

10 <string>$(EXECUTABLE_NAME)</string>	10 <string>$(EXECUTABLE_NAME)</string>

11 <key>CFBundleIcons</key>	11 <key>CFBundleIcons</key>

12 <dict/>	12 <dict/>

13 <key>CFBundleIcons~ipad</key>	13 <key>CFBundleIcons~ipad</key>

14 <dict/>	14 <dict/>

15 <key>CFBundleIdentifier</key>	15 <key>CFBundleIdentifier</key>

16 <string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>	16 <string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>

17 <key>CFBundleInfoDictionaryVersion</key>	17 <key>CFBundleInfoDictionaryVersion</key>

18 <string>6.0</string>	18 <string>6.0</string>

19 <key>CFBundleName</key>	19 <key>CFBundleName</key>

20 <string>$(PRODUCT_NAME)</string>	20 <string>$(PRODUCT_NAME)</string>

21 <key>CFBundlePackageType</key>	21 <key>CFBundlePackageType</key>

22 <string>XPC!</string>	22 <string>XPC!</string>

23 <key>CFBundleShortVersionString</key>	23 <key>CFBundleShortVersionString</key>

24 <string>2.0.0</string>	24 <string>2.0.0</string>

25 <key>CFBundleSignature</key>	25 <key>CFBundleSignature</key>

26 <string>????</string>	26 <string>????</string>

27 <key>CFBundleVersion</key>	27 <key>CFBundleVersion</key>

28 <string>2.0.0</string>	28 <string>$(BUILD_NUMBER)</string>
d108 2018/04/06 23:23:58 I suggest reverting CFBundleVersion to be the buil I suggest reverting CFBundleVersion to be the build number for now as this will be needed for the app store. I also suggest this be a user defined value such as $CORE_BUILD_NUMBER so that when we use custom configurations that we, or CI,can assign different values to each build type such as devbuild, release, etc.
29 <key>NSExtension</key>	29 <key>NSExtension</key>

30 <dict>	30 <dict>

31 <key>NSExtensionAttributes</key>	31 <key>NSExtensionAttributes</key>

32 <dict>	32 <dict>

33 <key>NSExtensionActivationRule</key>	33 <key>NSExtensionActivationRule</key>

34 <string>SUBQUERY(extensionItems, $extensionItem, SUBQUERY( $exte nsionItem.attachments, $attachment, ANY $attachment.registeredTypeIdentifiers UT I-CONFORMS-TO "public.url" ).@count == 1).@count == 1</string>	34 <string>SUBQUERY(extensionItems, $extensionItem, SUBQUERY( $exte nsionItem.attachments, $attachment, ANY $attachment.registeredTypeIdentifiers UT I-CONFORMS-TO "public.url" ).@count == 1).@count == 1</string>

35 </dict>	35 </dict>

36 <key>NSExtensionPointIdentifier</key>	36 <key>NSExtensionPointIdentifier</key>

37 <string>com.apple.share-services</string>	37 <string>com.apple.share-services</string>

38 <key>NSExtensionPrincipalClass</key>	38 <key>NSExtensionPrincipalClass</key>

39 <string>ShareViewController</string>	39 <string>ShareViewController</string>

40 </dict>	40 </dict>

41 </dict>	41 </dict>

42 </plist>	42 </plist>

LEFT	RIGHT