Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(354)

Issue 29743730: Issue 6559 - Use maps and sets where appropriate (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 8 months ago by Manish Jethani
Modified:
1 year, 8 months ago
Reviewers:
kzar
CC:
sergei
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Total comments: 14

Patch Set 2 : Update comments #

Total comments: 2

Patch Set 3 : Revert logic in getUnconditionalFilterKeys #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -48 lines) Patch
M lib/downloader.js View 4 chunks +7 lines, -6 lines 0 comments Download
M lib/elemHide.js View 1 2 7 chunks +38 lines, -35 lines 0 comments Download
M lib/elemHideEmulation.js View 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 8
Manish Jethani
1 year, 8 months ago (2018-04-05 17:38:23 UTC) #1
Manish Jethani
Patch Set 1 https://codereview.adblockplus.org/29743730/diff/29743731/lib/elemHide.js File lib/elemHide.js (right): https://codereview.adblockplus.org/29743730/diff/29743731/lib/elemHide.js#newcode94 lib/elemHide.js:94: for (let collection of [keyByFilter, filtersByDomain, ...
1 year, 8 months ago (2018-04-06 05:36:16 UTC) #2
kzar
https://codereview.adblockplus.org/29743730/diff/29743731/lib/elemHide.js File lib/elemHide.js (right): https://codereview.adblockplus.org/29743730/diff/29743731/lib/elemHide.js#newcode73 lib/elemHide.js:73: * Lookup table, keys are known element hiding exceptions ...
1 year, 8 months ago (2018-04-06 11:42:20 UTC) #3
Manish Jethani
Patch Set 2: Update comments https://codereview.adblockplus.org/29743730/diff/29743731/lib/elemHide.js File lib/elemHide.js (right): https://codereview.adblockplus.org/29743730/diff/29743731/lib/elemHide.js#newcode73 lib/elemHide.js:73: * Lookup table, keys ...
1 year, 8 months ago (2018-04-06 12:44:09 UTC) #4
kzar
https://codereview.adblockplus.org/29743730/diff/29743731/lib/elemHide.js File lib/elemHide.js (right): https://codereview.adblockplus.org/29743730/diff/29743731/lib/elemHide.js#newcode298 lib/elemHide.js:298: if (!unconditionalFilterKeys) On 2018/04/06 12:44:09, Manish Jethani wrote: > ...
1 year, 8 months ago (2018-04-06 13:07:55 UTC) #5
Manish Jethani
Patch Set 3: Revert logic in getUnconditionalFilterKeys https://codereview.adblockplus.org/29743730/diff/29743731/lib/elemHide.js File lib/elemHide.js (right): https://codereview.adblockplus.org/29743730/diff/29743731/lib/elemHide.js#newcode298 lib/elemHide.js:298: if (!unconditionalFilterKeys) ...
1 year, 8 months ago (2018-04-06 13:34:38 UTC) #6
Manish Jethani
https://codereview.adblockplus.org/29743730/diff/29743731/lib/elemHide.js File lib/elemHide.js (right): https://codereview.adblockplus.org/29743730/diff/29743731/lib/elemHide.js#newcode364 lib/elemHide.js:364: if (seenFilters.has(filterKey)) On 2018/04/06 12:44:09, Manish Jethani wrote: > ...
1 year, 8 months ago (2018-04-06 13:44:11 UTC) #7
kzar
1 year, 8 months ago (2018-04-06 14:26:35 UTC) #8
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5