Noissue - Trim spaces around element hiding emulation selectors

test/filterClasses.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 417 matching lines @@
              "!  fo  o##  bar");
 
   // Element hiding filters
   test.equal(Filter.normalize("   domain.c  om## # sele ctor   "),
              "domain.com### sele ctor");
 
   // Element hiding emulation filters
   test.equal(Filter.normalize("   domain.c  om#?# # sele ctor   "),
              "domain.com#?## sele ctor");
 
+  // Incorrect syntax: the separator "#?#" cannot contain spaces; treated as a
+  // regular filter instead
+  test.equal(Filter.normalize("   domain.c  om# ?#. sele ctor   "),
+             "domain.com#?#.selector");
+  // Incorrect syntax: the separator "#?#" cannot contain spaces; treated as an
+  // element hiding filter instead, because the "##" following the "?" is taken
+  // to be the separator instead
+  test.equal(Filter.normalize("   domain.c  om# ?##sele ctor   "),
+             "domain.com#?##sele ctor");
+
   // Element hiding exception filters
   test.equal(Filter.normalize("   domain.c  om#@# # sele ctor   "),
              "domain.com#@## sele ctor");
+
+  // Incorrect syntax: the separator "#@#" cannot contain spaces; treated as a
+  // regular filter instead (not an element hiding filter either!), because
+  // unlike the case with "# ?##" the "##" following the "@" is not considered
+  // to be a separator
+  test.equal(Filter.normalize("   domain.c  om# @## sele ctor   "),
+             "domain.com#@##selector");
 
   // Regular filters
   let normalized = Filter.normalize(
     "    b$l     a$sitekey=  foo  ,domain= do main.com |foo   .com,c sp= c   s p  "
   );
   test.equal(
     normalized,
     "b$la$sitekey=foo,domain=domain.com|foo.com,csp=c s p"
   );
   compareFilter(
@@ skipping 25 matching lines @@
              "foo$csp=bar,$csp=c s p");
   test.equal(Filter.normalize(" f o   o   $      bar   $csp=ba r"),
              "foo$bar$csp=ba r");
   test.equal(Filter.normalize("f    $    o    $    o    $    csp=f o o "),
              "f$o$o$csp=f o o");
   test.equal(Filter.normalize("/foo$/$ csp = script-src  http://example.com/?$1=1&$2=2&$3=3"),
              "/foo$/$csp=script-src http://example.com/?$1=1&$2=2&$3=3");
 
   test.done();
 };