Issue 6531 - remove inspector and adapt for Android NDK r16b

src/arm/simulator-arm.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Declares a Simulator for ARM instructions if we are not generating a native
 // ARM binary. This Simulator allows us to run and debug ARM code generation on
 // regular desktop machines.
 // V8 calls into generated code by using the GeneratedCode class,
 // which will start execution in the Simulator or forwards to the real entry
 // on a ARM HW platform.
@@ skipping 195 matching lines @@
     bad_lr = -1,
     // A pc value used to signal the simulator to stop execution.  Generally
     // the lr is set to this value on transition from native C code to
     // simulated execution, so that the simulator can "return" to the native
     // C code.
     end_sim_pc = -2
   };
 
   V8_EXPORT_PRIVATE intptr_t CallImpl(byte* entry, int argument_count,
                                       const intptr_t* arguments);
-  intptr_t CallFPImpl(byte* entry, double d0, double d1);
+  int32_t CallFPImpl(byte* entry, double d0, double d1);

[sergei, 2018/04/09 09:48:10]

Compare
https://chromium.googlesource.com/v8/v8.git/+/7fece33157c55b16decdf4cde199ca3...
https://chromium.googlesource.com/v8/v8.git/+/7fece33157c55b16decdf4cde199ca3...

However the compiler stumbles upon it, AFAIR intptr_t is defined as 64 bit or it
simply cannot convert one type (int32_t) to the type of pointer.

[hub, 2018/04/11 01:55:14]

In master
https://chromium.googlesource.com/v8/v8.git/+/master/src/arm/simulator-arm.cc
the signature in the implementation is intptr_t. Maybe that's where it should be
changed instead?

[sergei, 2018/04/11 09:34:44]

Done, perhaps it's better. When I was changing it I took a look at the return
value of `get_register` which return value is returned from this function.

 
   // Unsupported instructions use Format to print an error and stop execution.
   void Format(Instruction* instr, const char* format);
 
   // Checks if the current instruction should be executed based on its
   // condition bits.
   inline bool ConditionallyExecute(Instruction* instr);
 
   // Helper functions to set the conditional flags in the architecture state.
   void SetNZFlags(int32_t val);
@@ skipping 267 matching lines @@
   LocalMonitor local_monitor_;
   GlobalMonitor::Processor global_monitor_processor_;
   static base::LazyInstance<GlobalMonitor>::type global_monitor_;
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // defined(USE_SIMULATOR)
 #endif  // V8_ARM_SIMULATOR_ARM_H_